Skip to content

perf: speed up self-update by calling /releases/latest api instead of /releases #4619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Mar 12, 2025
Merged

perf: speed up self-update by calling /releases/latest api instead of /releases #4619

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 16 additions & 31 deletions src/cli/self_update.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
use color_eyre::Result;
use color_eyre::eyre::bail;
use console::style;
use self_update::backends::github::{ReleaseList, Update};
use self_update::update::Release;
use self_update::backends::github::Update;
use self_update::{Status, cargo_crate_version};

use crate::cli::version::{ARCH, OS};
Expand Down Expand Up @@ -55,56 +54,42 @@ impl SelfUpdate {
Ok(())
}

fn fetch_releases(&self) -> Result<Vec<Release>> {
let mut releases = ReleaseList::configure();
fn do_update(&self) -> Result<Status> {
let mut update = Update::configure();
if let Some(token) = &*env::GITHUB_TOKEN {
releases.auth_token(token);
update.auth_token(token);
}
let releases = releases
#[cfg(windows)]
let bin_path_in_archive = "mise/bin/mise.exe";
#[cfg(not(windows))]
let bin_path_in_archive = "mise/bin/mise";
update
.repo_owner("jdx")
.repo_name("mise")
.build()?
.fetch()?;
Ok(releases)
}

fn latest_version(&self) -> Result<String> {
let releases = self.fetch_releases()?;
Ok(releases[0].version.clone())
}
.bin_name("mise")
.current_version(cargo_crate_version!())
.bin_path_in_archive(bin_path_in_archive);

fn do_update(&self) -> Result<Status> {
let settings = Settings::try_get();
let v = self
.version
.clone()
.map_or_else(|| self.latest_version(), Ok)
.map_or_else(
|| -> Result<String> { Ok(update.build()?.get_latest_release()?.version) },
Ok,
)
.map(|v| format!("v{}", v))?;
let target = format!("{}-{}", *OS, *ARCH);
let mut update = Update::configure();
if let Some(token) = &*env::GITHUB_TOKEN {
update.auth_token(token);
}
if self.force || self.version.is_some() {
update.target_version_tag(&v);
}
#[cfg(windows)]
let target = format!("mise-{v}-{target}.zip");
#[cfg(not(windows))]
let target = format!("mise-{v}-{target}.tar.gz");
#[cfg(windows)]
let bin_path_in_archive = "mise/bin/mise.exe";
#[cfg(not(windows))]
let bin_path_in_archive = "mise/bin/mise";
let status = update
.repo_owner("jdx")
.repo_name("mise")
.bin_name("mise")
.verifying_keys([*include_bytes!("../../zipsign.pub")])
.show_download_progress(true)
.current_version(cargo_crate_version!())
.target(&target)
.bin_path_in_archive(bin_path_in_archive)
.target(&target)
.no_confirm(settings.is_ok_and(|s| s.yes) || self.yes)
.build()?
Expand Down