Skip to content

chore: remove rustup update in github actions #4617

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Mar 12, 2025
Merged

chore: remove rustup update in github actions #4617

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions .github/workflows/release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,7 @@ jobs:
key: cargo-registry-${{ hashFiles('**/Cargo.lock') }}
restore-keys: cargo-registry
- if: matrix.runs-on != 'ubuntu-latest'
# TODO: remove rustup update once 1.85.0 is released to images
run: rustup update && rustup target add ${{matrix.target}}
run: rustup target add ${{matrix.target}}
- if: matrix.runs-on == 'ubuntu-latest'
uses: taiki-e/install-action@cross
- name: build-tarball
Expand Down Expand Up @@ -116,8 +115,7 @@ jobs:
target: x86_64-pc-windows-msvc
steps:
- uses: actions/checkout@v4
# TODO: remove rustup update once 1.85.0 is released to images
- run: rustup update && rustup target add ${{matrix.target}}
- run: rustup target add ${{matrix.target}}
- uses: Swatinem/rust-cache@v2
with:
key: ${{matrix.arch}}
Expand Down
4 changes: 0 additions & 4 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,6 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: true
- run: rustup update # TODO: remove when 1.85.0 is released to build images
- uses: Swatinem/rust-cache@v2
with:
shared-key: build
Expand Down Expand Up @@ -94,7 +93,6 @@ jobs:
- uses: actions/checkout@v4
with:
submodules: true
- run: rustup update # TODO: remove when 1.85.0 is released to build images
- uses: Swatinem/rust-cache@v2
with:
shared-key: build
Expand Down Expand Up @@ -132,7 +130,6 @@ jobs:
repository: ${{ github.event.pull_request.head.repo.full_name }}
ref: ${{ github.head_ref }}
submodules: true
- run: rustup update # TODO: remove when 1.85.0 is released to build images
- uses: rui314/setup-mold@v1
if: ${{ matrix.os == 'ubuntu-latest' }}
- uses: taiki-e/install-action@v2
Expand Down Expand Up @@ -248,7 +245,6 @@ jobs:
MISE_CACHE_DIR: ~/.cache/mise
steps:
- uses: actions/checkout@v4
- run: rustup update # TODO: remove when 1.85.0 is released to build images
- uses: Swatinem/rust-cache@v2
with:
shared-key: unit
Expand Down