Skip to content

feat: cleanup the mutex use.#4540

Merged
jdx merged 4 commits into
jdx:mainfrom
klarrio-oss:small-cleanup
Mar 12, 2025
Merged

feat: cleanup the mutex use.#4540
jdx merged 4 commits into
jdx:mainfrom
klarrio-oss:small-cleanup

Conversation

@boris-smidt-klarrio

@boris-smidt-klarrio boris-smidt-klarrio commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

refactor: the condition on when the task runner finishes.
refactor: use the insert boolean instead of a !contains
feature: infinitive loop detection

@autofix-ci

autofix-ci Bot commented Feb 26, 2025

Copy link
Copy Markdown
Contributor

Hi! I'm autofix logoautofix.ci, a bot that automatically fixes trivial issues such as code formatting in pull requests.

I would like to apply some automated changes to this pull request, but it looks like I don't have the necessary permissions to do so. To get this pull request into a mergeable state, please do one of the following two things:

  1. Allow edits by maintainers for your pull request, and then re-trigger CI (for example by pushing a new commit).
  2. Manually fix the issues identified for your pull request (see the GitHub Actions output for details on what I would like to change).

@boris-smidt-klarrio boris-smidt-klarrio changed the title refactor: cleanup the mutex use. feature: cleanup the mutex use. Feb 26, 2025
@jdx

jdx commented Feb 26, 2025

Copy link
Copy Markdown
Owner

it would be ideal if we could have some e2e tests but I also realize that might be very difficult with this sort of change

@boris-smidt-klarrio

boris-smidt-klarrio commented Feb 26, 2025

Copy link
Copy Markdown
Contributor Author

I can add a the case of pr #4539
I'm not sure if i can really make a test for it since it catches the post_depends issue.

@boris-smidt-klarrio

Copy link
Copy Markdown
Contributor Author

@jdx could we get this one merged to avoid people having to wait forever in there github actions?

@jdx jdx changed the title feature: cleanup the mutex use. feat: cleanup the mutex use. Mar 12, 2025
@jdx jdx merged commit 74738db into jdx:main Mar 12, 2025
@boris-smidt-klarrio

Copy link
Copy Markdown
Contributor Author

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants