Skip to content

feat: build erlang with all cores #3802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 23, 2024
Merged

feat: build erlang with all cores #3802

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0cf97b0
feat: build erlang with all cores
jdx Dec 23, 2024
eac8299
Merge branch 'main' into erlang
jdx Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/test-plugins.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,12 +57,12 @@ jobs:
- plugin: direnv
command: mise exec direnv@latest -- direnv --version
- plugin: erlang
command: mise exec erlang@24.3.4.9 -- erl -eval 'erlang:display(erlang:system_info(otp_release)), halt().' -noshell
command: mise exec erlang@27.2 -- erl -eval 'erlang:display(erlang:system_info(otp_release)), halt().' -noshell
- plugin: elixir
command: |
mise use --global erlang@24.3.4.9
mise use --global erlang@27.2
eval "$(mise env bash)"
mise use --global elixir
mise use --global elixir@1.17.3
eval "$(mise env bash)"
mise exec -- elixir --version
- plugin: golang
Expand Down
5 changes: 2 additions & 3 deletions src/plugins/core/erlang.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,6 @@ impl ErlangPlugin {
self.install_kerl()?;
cmd!(self.kerl_path(), "update", "releases")
.env("KERL_BASE_DIR", self.kerl_base_dir())
.stdout_to_stderr()
.run()?;
Ok(())
}
Expand All @@ -73,7 +72,7 @@ impl ErlangPlugin {
ctx: &InstallContext,
mut tv: ToolVersion,
) -> Result<Option<ToolVersion>> {
if SETTINGS.erlang.compile == Some(false) {
if SETTINGS.erlang.compile == Some(true) {
return Ok(None);
}
let release_tag = format!("OTP-{}", tv.version);
Expand Down Expand Up @@ -126,7 +125,7 @@ impl ErlangPlugin {
tv.install_path()
)
.env("KERL_BASE_DIR", self.ba.cache_path.join("kerl"))
.stdout_to_stderr()
.env("MAKEFLAGS", format!("-j{}", num_cpus::get()))
.run()?;
}
}
Expand Down
Loading