Skip to content

fix: some bugs with lockfiles#3113

Merged
jdx merged 1 commit into
mainfrom
vfox-fix
Nov 21, 2024
Merged

fix: some bugs with lockfiles#3113
jdx merged 1 commit into
mainfrom
vfox-fix

Conversation

@jdx

@jdx jdx commented Nov 21, 2024

Copy link
Copy Markdown
Owner

No description provided.

@jdx jdx force-pushed the vfox-fix branch 3 times, most recently from 1ca4119 to f7a3f7c Compare November 21, 2024 12:24
@github-actions

github-actions Bot commented Nov 21, 2024

Copy link
Copy Markdown

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main x -- echo 15.1 ± 0.4 14.3 17.0 1.02 ± 0.04
mise-2024.11.20 x -- echo 14.8 ± 0.4 14.0 16.8 1.00
mise x -- echo 15.7 ± 0.6 14.3 18.3 1.06 ± 0.05

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main env 12.1 ± 0.6 11.1 17.1 1.06 ± 0.06
mise-2024.11.20 env 11.4 ± 0.3 10.9 14.1 1.00
mise env 11.5 ± 0.3 11.0 13.1 1.01 ± 0.04

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main hook-env 12.2 ± 0.4 11.3 13.3 1.05 ± 0.05
mise-2024.11.20 hook-env 11.7 ± 0.3 10.9 12.7 1.01 ± 0.04
mise hook-env 11.6 ± 0.3 10.8 13.4 1.00

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-main ls 12.4 ± 0.4 11.8 14.5 1.03 ± 0.05
mise-2024.11.20 ls 12.1 ± 0.3 11.4 13.2 1.00
mise ls 12.8 ± 0.4 12.0 14.5 1.06 ± 0.05

@jdx jdx force-pushed the vfox-fix branch 4 times, most recently from 364659d to 50998ce Compare November 21, 2024 14:09
@codacy-production

Copy link
Copy Markdown

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
-0.02% 69.92%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (716b050) 21506 16926 78.70%
Head commit (8d75ce3) 21543 (+37) 16951 (+25) 78.68% (-0.02%)

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#3113) 123 86 69.92%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

@jdx jdx merged commit 2eb731d into main Nov 21, 2024
@jdx jdx deleted the vfox-fix branch November 21, 2024 14:24
@freak4pc

Copy link
Copy Markdown

Could be that this caused some regression?

Our CI started failing yesterday, we never had to set the flag to experimental and I don't think we actually have a separate lockfile?

+ curl https://mise.run/
+ sh

######################################################################## 100.0%
mise: installed successfully to /Users/vagrant/.local/bin/mise

+ mise install
mise plugin:maestro  clone https://github.com/dotanuki-labs/asdf-maestro.git
mise plugin:maestro ✓ https://github.com/dotanuki-labs/asdf-maestro.git#cd2c5a0
mise plugin:tuist    clone https://github.com/asdf-community/asdf-tuist.git
mise plugin:tuist  ✓ https://github.com/asdf-community/asdf-tuist.git#44c87b2
mise ERROR lockfile is experimental. Enable it with `mise settings set experimental true`
mise ERROR Run with --verbose or MISE_VERBOSE=1 for more information

@jdx

jdx commented Nov 22, 2024

Copy link
Copy Markdown
Owner Author

yes but it should be fixed in the latest release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants