feat(tasks): make script task dirs configurable#1571
Merged
Conversation
774ce00 to
c0901bc
Compare
jdx
reviewed
Jan 31, 2024
| #[serde(default)] | ||
| plugins: HashMap<String, String>, | ||
| #[serde(skip)] | ||
| pub task_config: TaskConfig, |
Owner
There was a problem hiding this comment.
can you change this to parse via derive? I'm trying to get rid of the manual parsing
Contributor
Author
There was a problem hiding this comment.
Yes, that's what I actually started with, but didn't quite understand how templates are being rendered to the deserialized values.
Contributor
Author
There was a problem hiding this comment.
nvm, I see now. Was looking in the wrong place.
mise/src/config/env_directive.rs
Lines 151 to 165 in 3070bf8
Contributor
Author
There was a problem hiding this comment.
Just dropping support for templating in includes for now. It just adds too much noise for the moment and will be simpler to incorporate after custom parsing is gone.
c0901bc to
1670484
Compare
1670484 to
5f50669
Compare
jdx
pushed a commit
that referenced
this pull request
Aug 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #1270
Adds a top-level config Table,
task_config, which currently has one propertyincludes.includesis an array of paths which can be used to alter the locations from which file tasks are loaded from.These paths can be absolute, relative, inside/outside the project, and accepts
~as a substitution for$HOME.Additional Notes
includesis represented as aBTreeSetto preserve ordering, allows users to influence load ordering, and to ensure uniqueness.