Skip to content

registry: drop perl depends from cloc - #12335

Merged
jdx merged 2 commits into
jdx:mainfrom
risu729:registry/cloc-drop-perl-depends
Aug 27, 2026
Merged

jdx merged 2 commits into
jdx:mainfrom
risu729:registry/cloc-drop-perl-depends

Conversation

@risu729

@risu729 risu729 commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Remove depends = ["perl"] from the cloc registry entry added in Add cloc to the registry using the GitHub backend #12280.
  • Windows installs the standalone cloc-{{ version }}.exe, which already embeds Perl and does not need a Perl interpreter.
  • depends is not platform-specific, so that declaration would apply on Windows too. It also does not install Perl; it only orders installs when perl is already in the toolset. Unix/macOS .pl assets still run via #!/usr/bin/env perl against whatever Perl is on PATH.

Test plan

  • Confirm registry/cloc.toml no longer declares depends
  • On Windows, mise install cloc uses the .exe asset and cloc --version works without mise perl
  • On Linux/macOS, cloc --version still works with system Perl

AI-assisted — Tool: Cursor; model: SpaceXAI/Cursor Grok 4.6; version: unavailable.

Made with Cursor

Summary by CodeRabbit

  • Chores
    • Removed an unnecessary backend dependency from the cloc registry configuration.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 44d8ac30-24eb-48ec-b1b5-2ca1804aec02

📥 Commits

Reviewing files that changed from the base of the PR and between 0ddd8e3 and ea17b7a.

📒 Files selected for processing (1)
  • registry/cloc.toml
💤 Files with no reviewable changes (1)
  • registry/cloc.toml

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The cloc registry declaration no longer lists Perl as a backend dependency.

Changes

cloc dependency cleanup

Layer / File(s) Summary
Remove Perl dependency
registry/cloc.toml
Removed the perl backend dependency declaration.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to ea17b

This is a narrowly scoped registry change removing an unnecessary Perl dependency from cloc; no actionable merge-blocking risk remains beyond normal checks and review.

Poem

I nibbled the config, neat and light,
One dependency took flight.
No Perl to track,
A cleaner cloc stack,
Squeak—this patch is just right!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the Perl dependency from the cloc registry entry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the global Perl dependency-ordering declaration from the cloc registry entry because Windows uses a standalone executable while Unix assets rely on Perl already available on PATH.

  • Removes depends = ["perl"] from the cloc GitHub backend configuration.
  • Leaves all platform-specific asset mappings unchanged.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
registry/cloc.toml Removes cloc’s Perl installation-order dependency without changing its platform asset selection or installed binary name.

Reviews (3): Last reviewed commit: "Merge branch 'main' into registry/cloc-d..." | Re-trigger Greptile

Windows ships a standalone .exe that already embeds Perl. depends would also apply there, and it only orders installs when perl is already in the toolset.
@risu729
risu729 force-pushed the registry/cloc-drop-perl-depends branch from 10b9169 to 8ba0e4a Compare August 23, 2026 14:37
@risu729
risu729 marked this pull request as ready for review August 23, 2026 14:44
@github-actions

Copy link
Copy Markdown
Contributor

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 1 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

@github-actions

Copy link
Copy Markdown
Contributor

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 2 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

@github-actions

Copy link
Copy Markdown
Contributor

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 3 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

@coderabbitai

coderabbitai Bot commented Aug 26, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@jdx
jdx merged commit d932947 into jdx:main Aug 27, 2026
36 checks passed
@risu729
risu729 deleted the registry/cloc-drop-perl-depends branch September 4, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants