Repository navigation
registry: drop perl depends from cloc - #12335
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe cloc registry declaration no longer lists Perl as a backend dependency. Changescloc dependency cleanup
Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This is a narrowly scoped registry change removing an unnecessary Perl dependency from cloc; no actionable merge-blocking risk remains beyond normal checks and review. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR removes the global Perl dependency-ordering declaration from the cloc registry entry because Windows uses a standalone executable while Unix assets rely on Perl already available on
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "Merge branch 'main' into registry/cloc-d..." | Re-trigger Greptile |
Windows ships a standalone .exe that already embeds Perl. depends would also apply there, and it only orders installs when perl is already in the toolset.
10b9169 to
8ba0e4a
Compare
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 1 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 2 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 3 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
Summary
depends = ["perl"]from theclocregistry entry added in Add cloc to the registry using the GitHub backend #12280.cloc-{{ version }}.exe, which already embeds Perl and does not need a Perl interpreter.dependsis not platform-specific, so that declaration would apply on Windows too. It also does not install Perl; it only orders installs whenperlis already in the toolset. Unix/macOS.plassets still run via#!/usr/bin/env perlagainst whatever Perl is onPATH.Test plan
registry/cloc.tomlno longer declaresdependsmise install clocuses the.exeasset andcloc --versionworks without miseperlcloc --versionstill works with system PerlAI-assisted — Tool: Cursor; model: SpaceXAI/Cursor Grok 4.6; version: unavailable.
Made with Cursor
Summary by CodeRabbit