Skip to content

feat(java): enable oracle graalvm innovation releases - #12189

Merged
jdx merged 2 commits into
jdx:mainfrom
roele:issues/java-oraclegraalvm
Aug 20, 2026
Merged

jdx merged 2 commits into
jdx:mainfrom
roele:issues/java-oraclegraalvm

Conversation

@roele

@roele roele commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features
    • Added support for the Java “innovation” feature when identifying Java versions.

Copilot AI balanced review requested due to automatic review settings August 19, 2026 22:26
@coderabbitai

coderabbitai Bot commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 52e16502-bfcd-46ea-acd4-a36fce35c3ae

📥 Commits

Reviewing files that changed from the base of the PR and between c2a0cb9 and c74c752.

📒 Files selected for processing (1)
  • src/plugins/core/java.rs
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/plugins/core/java.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The Java plugin now recognizes the innovation feature when it constructs Java version identifiers.

Changes

Java feature support

Layer / File(s) Summary
Extend Java feature declarations
src/plugins/core/java.rs
JAVA_FEATURES now includes the innovation feature.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to c74c7

This localized Java plugin change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Poem

A rabbit adds one feature bright,
innovation joins the list just right.
Java versions now understand,
This new feature close at hand.
Hop, hop—change is planned!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: enabling Oracle GraalVM Innovation releases in Java support.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables Oracle GraalVM "innovation" (non-LTS) releases in the Java core plugin by adding "innovation" to the JAVA_FEATURES whitelist. That whitelist determines which feature tags are appended to a Java build's version string; without the tag, innovation builds would collapse onto non-feature version strings and be indistinguishable/unselectable. The change fits into the existing feature-filtering logic in to_version_string.

Changes:

  • Added "innovation" to the JAVA_FEATURES set, keeping alphabetical ordering.
  • Reformatted the set initializer to a multi-line array (required once the extra element exceeds the line width).

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@greptile-apps

greptile-apps Bot commented Aug 19, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds Oracle GraalVM innovation releases to Java’s recognized feature set.

  • Adds innovation to the Java metadata feature allowlist.
  • Reformats the allowlist for readability.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/plugins/core/java.rs Extends Java metadata version identification to recognize the innovation feature; no eligible follow-up defect was established.

Reviews (2): Last reviewed commit: "Merge branch 'main' into issues/java-ora..." | Re-trigger Greptile

@github-actions

Copy link
Copy Markdown
Contributor

This PR currently has failing checks. If this continues for 7 days, it will be closed automatically.

This is warning day 1 of 7.

Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it.

This comment was generated by an automated workflow.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@jdx
jdx merged commit 8dd2c77 into jdx:main Aug 20, 2026
30 checks passed
@roele
roele deleted the issues/java-oraclegraalvm branch August 20, 2026 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants