Skip to content

mise: armv7: use hf suffix for gnueabi - #12082

Merged
jdx merged 1 commit into
jdx:mainfrom
neheb:hf
Aug 17, 2026
Merged

jdx merged 1 commit into
jdx:mainfrom
neheb:hf

Conversation

@neheb

@neheb neheb commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Fixes usage on Debian 11/12 and armhf.

Summary by CodeRabbit

  • Chores
    • Updated Linux ARMv7 release builds to use the hard-float target.
    • Updated the ARMv7 cross-compilation environment to match, improving compatibility for supported ARMv7 devices.

Fixes usage on Debian 11/12 and armhf.

Signed-off-by: Rosen Penev <rosenp@gmail.com>
@coderabbitai

coderabbitai Bot commented Aug 17, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: ff707885-938f-49c0-aea8-88c85fc4799a

📥 Commits

Reviewing files that changed from the base of the PR and between 5d15625 and 053d697.

📒 Files selected for processing (2)
  • .github/workflows/release.yml
  • Cross.toml

Included review availability: Your plan includes up to 10 reviews per rolling hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The ARMv7 GNU target changed from soft-float to hard-float in Cross.toml and the release workflow. The cross-compilation image now matches the hard-float target.

Changes

ARMv7 hard-float target update

Layer / File(s) Summary
Cross-compilation target and release matrix
Cross.toml, .github/workflows/release.yml
The ARMv7 target changed to armv7-unknown-linux-gnueabihf. Cross.toml now uses the corresponding pinned cross-rs 0.2.5 image.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Merge Risk: ⚪ Minimal · up to 053d6

The PR makes a localized ARMv7 GNU EABI naming update in the build and release configuration; no actionable merge-blocking risk remains after normal checks.

Suggested reviewers: jdx

Poem

A rabbit hops through targets bright,
Hard-float builds now take flight.
Cross images match the trail,
Release jobs follow without fail.
Carrots cheer the cleaner compile!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly describes the ARMv7 target change from gnueabi to the hard-float hf suffix.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Aug 17, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the ARMv7 GNU release build from the soft-float gnueabi target to the hard-float gnueabihf target for Debian armhf compatibility.

  • Aligns the release workflow’s ARMv7 Rust target with the hard-float ABI.
  • Selects the matching pinned cross-rs container image in Cross.toml.

Confidence Score: 5/5

The PR appears safe to merge with no actionable defects identified.

The workflow target and Cross configuration are updated consistently, while artifact naming and downstream ARMv7 release consumers remain unchanged.

Important Files Changed

Filename Overview
.github/workflows/release.yml Changes the ARMv7 release matrix target to armv7-unknown-linux-gnueabihf while preserving the existing artifact name and downstream release contract.
Cross.toml Renames the ARMv7 target configuration and image to the corresponding hard-float cross-rs target, keeping the existing armhf setup.

Reviews (1): Last reviewed commit: "mise: armv7: use hf suffix for gnueabi" | Re-trigger Greptile

@neheb

neheb commented Aug 17, 2026

Copy link
Copy Markdown
Contributor Author

The Cross.toml change is telling. This was always supposed to be hf.

@jdx
jdx merged commit ecd594f into jdx:main Aug 17, 2026
31 checks passed
@neheb
neheb deleted the hf branch August 17, 2026 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants