Repository navigation
chore(ci): install cmake for snapcraft builds - #11974
Conversation
Greptile SummaryAdds CMake to the Snapcraft build environment so CMake-dependent Rust crates can compile when producing Snap packages.
Confidence Score: 5/5The PR appears safe to merge, with no actionable build, runtime, or security issues identified. The added CMake package is available for the Snap build targets and directly supplies the executable required by CMake-dependent Rust crates without altering the resulting application’s runtime behavior. Important Files Changed
Reviews (1): Last reviewed commit: "chore(ci): install cmake for snapcraft b..." | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Snapcraft configuration adds ChangesSnapcraft build configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Mergeability Score: ⚪ Minimal · up to This localized change installs CMake for Snapcraft builds so the affected packages can compile; no actionable merge-blocking risk remains after normal checks and review. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Summary
cmakein the Snapcraft build environmentlibz-ng-systo compile for amd64 and arm64 Snap packagesContext
Snap publishing has failed since v2026.7.12 because
libz-ng-sysinvokes CMake, but the Snapcraft build environment does not include thecmakeexecutable. This leaves the stable Snap at v2026.7.11, as reported in discussion #11967.Validation
mise run lint-fixhksafe check (schema, formatting, shell, workflow, Markdown, andcargo check)AI-assisted — Tool: Codex; model: openai/GPT-5; version: unavailable.
Note
Low Risk
Packaging-only change to the Snap build environment; no runtime or application logic changes.
Overview
Adds
cmaketo the Snapcraftmisepartbuild-packagesso the Rust build can compilelibz-ng-sys(which runs CMake at build time).This aligns Snap packaging with other Linux release paths that already list CMake and should unblock amd64 and arm64 Snap publishes that have failed since v2026.7.12.
Reviewed by Cursor Bugbot for commit a7b3418. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit