[jdx]

Summary

• add support for Homebrew cask artifact stanzas
• constrain generic artifact targets to the Homebrew prefix
• preserve directory symlinks and platform metadata while copying
• include installed artifact paths in transactional rollback and receipt fingerprints

Context

This is the second PR in the cask lifecycle stack. It builds on #11962 and covers the generic prefix artifacts used by libcblite and libcblite-community.

Stack

1. feat(brew): support structured cask symlinks #11962
2. feat(brew): support generic cask artifacts #11963
3. feat(brew): support cask copy and installer steps #11964

Validation

• cargo test --bin mise system::packages::brew::cask::tests -- --test-threads=1
• cargo clippy --tests --bin mise -- -D warnings
• cargo fmt --all
• git diff --check

AI-assisted — Tool: Codex; model: OpenAI/GPT-5; version: unavailable.

---

Note

Medium Risk
Large new code path that writes under the Homebrew prefix and may elevate via sudo, but targets are constrained and heavily validated with extensive tests.

Overview
Adds Homebrew cask artifact support so staged trees can be copied into $HOMEBREW_PREFIX (e.g. libcblite include dirs), with docs updated to list generic prefix artifacts alongside existing cask types.

Install path copies files or directories into prefix-relative targets, records them on the cask receipt, cleans up obsolete paths on upgrade, and wires the install into the existing flight/transaction journal. Flight rollback now distinguishes elevated vs trusted unprivileged backups via an elevate flag on recovery records.

Security-focused Unix plumbing: openat-based trusted parent traversal, prefix/symlink validation, private staging directories, optional sudo when targets are root-owned, and nix dir/fs features for safe copies (including fcopyfile on macOS). Permission-denied detection also treats wrapped nix::errno errors as retry-with-sudo cases. Generic artifacts are excluded from prune-safe casks.

^{Reviewed by Cursor Bugbot for commit 222fc68. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: e0884c91-38ed-4b1c-b56a-eeb837cbfbe8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

The PR adds generic Homebrew cask artifacts, including prefix-target installation, transactional protection and recovery, receipt tracking, obsolete-target cleanup, and fd-relative filesystem operations for unprivileged Unix paths.

• Parses and validates generic artifact stanzas and installs their trees beneath the Homebrew prefix.
• Records generic targets in receipts and incorporates them into rollback, cleanup, and prune-safety behavior.
• Adds Unix descriptor-relative copy, rename, and removal helpers plus elevated fallbacks.
• Enables the required nix filesystem and directory features and updates brew-cask documentation.

Confidence Score: 3/5

The PR does not yet appear safe to merge because elevated generic-artifact operations can still be redirected outside the validated Homebrew prefix after a mutable path component is replaced.

The descriptor-bound changes protect unprivileged copying, cleanup, and rollback, but elevated copy, mkdir, cleanup, rollback, and recovery retain only canonicalized pathnames and pass them to sudo helpers that resolve them again after validation.

Files Needing Attention: src/system/packages/brew/cask.rs

Important Files Changed

Filename	Overview
src/system/packages/brew/cask.rs	Adds generic artifact lifecycle support and descriptor-relative unprivileged operations, but the elevated lifecycle still loses directory binding before privileged pathname mutations.
Cargo.toml	Enables the nix directory and filesystem features required by the new fd-relative helpers.
docs/bootstrap/packages/brew.md	Documents support for generic Homebrew-prefix artifact stanzas.

_{Reviews (48): Last reviewed commit: "feat(brew): support generic cask artifac..." | Re-trigger Greptile}

[github-actions]

Instruction counts

benchmark	trend	instructions	Δ	wall (min)	Δ
env	▄▃▂▁▄███▁	81,001,834 → 80,791,377	-0.26%	17.88 → 18.03ms	+0.86%
hook-env	▆▄▃▅▄██▇▁	82,487,466 → 82,352,676	-0.16%	18.92 → 19.34ms	+2.23%
ls	▁▃▃▂▃███▂	73,547,069 → 73,400,423	-0.20%	16.96 → 17.09ms	+0.79%
registry	▇█▅▆█▃▄▅▁	43,321,991 → 43,283,646	-0.09%	11.65 → 12.17ms	+4.46%
startup	▇▇▂▂▁▇▇█▃	15,583,457 → 15,569,166	-0.09%	9.60 → 9.77ms	+1.82%

No instruction-count regression above 1%.

_{Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.}

_{Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.}

_{222fc681943e vs 11d5eb2a1318 · measured on the runner, not pushed to the history.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit dcdd73a. Configure here.}