Repository navigation
fix(upgrade): deprecate ambiguous -l shorthand - #11945
Conversation
Greptile SummaryThe PR preserves the legacy
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "test(upgrade): cover deprecated bump sho..." | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
🚧 Files skipped from review as they are similar to previous changes (2)
📝 WalkthroughWalkthroughThe ChangesBump flag migration
Estimated code review effort: 3 (Moderate) | ~20 minutes Mergeability Score: ⚪ Minimal · up to This localized CLI and documentation change is merge-ready after normal checks and review; no actionable merge-blocking risk remains. Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@e2e/cli/test_outdated`:
- Around line 21-23: Extend the assertions for the deprecated -l alias to verify
it enables bump mode: in e2e/cli/test_outdated lines 21-23, assert that mise
outdated dummy -l reports version 2.0.0; in e2e/cli/test_upgrade lines 17-18,
assert that mise upgrade dummy -l --dry-run reports “Would install dummy@2.0.0”.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: e58cf0bb-ac3f-490b-a336-f2ad100e0e56
📒 Files selected for processing (7)
docs/cli/outdated.mddocs/cli/upgrade.mde2e/cli/test_outdatede2e/cli/test_upgrademise.usage.kdlsrc/cli/outdated.rssrc/cli/upgrade.rs
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Summary
-bas the visible shorthand for--bumponmise upgradeandmise outdated-lbump shorthand until mise 2027.8.5, after which it can be reassigned to--local--bumpcandidate exists, explain that newer versions are available outside those rangesMotivation
-lwas originally chosen to mean “latest,” even though its long-form flag is--bump. That is surprising and prevents the natural-lshorthand for the existing--localoption. It also contributed to misleading “All tools are up to date” output for exact pins.Validation
mise run lint-fixcargo check --all-features --lockedmise run test:e2e e2e/cli/test_outdated e2e/cli/test_upgrademise run render:usageAI-assisted — Tool: Codex; model: OpenAI/GPT-5; version: unavailable.
Note
Low Risk
Backward-compatible CLI deprecation with tests and docs; behavior change is limited to flag shorthands and clearer “up to date” messaging.
Overview
mise outdatedandmise upgradenow expose-bas the primary shorthand for--bump. The old-lbump shorthand is hidden from help, still accepted with adeprecated_at!warning (removal planned 2027.8.5), and documented so-lcan later mean--local.When tools are current within configured version ranges but a
--bump-style upgrade would be available, both commands print an info line pointing users to--bumpinstead of the previous generic hint.Generated CLI docs (
docs/cli,man,mise.usage.kdl) and e2e tests cover help text,-b/-lbehavior, and the new message.Reviewed by Cursor Bugbot for commit e69a911. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
outdatedandupgradecommands to use-bas the shorthand for--bump.-lwith deprecation warnings; it will later be reassigned to--local.