Repository navigation
fix(npm): render lifecycle logs through progress - #11939
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthrough
ChangesAube lifecycle output
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This change narrowly improves npm lifecycle log rendering while preserving existing warning and error handling; no actionable merge-blocking risk remains beyond normal checks and review. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Greptile SummaryThe PR updates the embedded aube workspace crates to 1.40.0 and routes tagged lifecycle-script output through the active progress report.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (7): Last reviewed commit: "test(npm): tolerate shell output whitesp..." | Re-trigger Greptile |
19a80c1 to
a6a5424
Compare
There was a problem hiding this comment.
🧹 Nitpick comments (1)
src/backend/npm.rs (1)
2638-2653: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winCover the negative side of the event-code filter.
The test verifies only
AUBE_LIFECYCLE_SCRIPT_OUTPUT. Add cases for informational events with no code and with a different code. Assert thatRecordingReportremains empty. This protects the existing debug-only path from a future broad match.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@src/backend/npm.rs` around lines 2638 - 2653, Extend test_aube_lifecycle_output_prints_through_progress_report with informational InstallEvent::Output cases using None and a different code, and assert RecordingReport remains empty for each. Keep the existing AUBE_LIFECYCLE_SCRIPT_OUTPUT assertion unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@src/backend/npm.rs`:
- Around line 2638-2653: Extend
test_aube_lifecycle_output_prints_through_progress_report with informational
InstallEvent::Output cases using None and a different code, and assert
RecordingReport remains empty for each. Keep the existing
AUBE_LIFECYCLE_SCRIPT_OUTPUT assertion unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 526ae473-163a-45ef-aaf3-ea3cf3c7982e
📒 Files selected for processing (1)
src/backend/npm.rs
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d3ad5f0. Configure here.
5b6c63d to
ecba04a
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|

Summary
SingleReport, so clx safely redraws concurrent progress jobsDependency
InstallEvent::OutputeventsTests
cargo check --lockedcargo test --locked --bin mise aubecargo test --locked --bin mise task::workspace::node::testsmise run test:e2e e2e/backend/test_npm_aubeAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Summary by CodeRabbit
Bug Fixes
Tests
Note
Low Risk
Scoped to npm embedded-aube install UX and a dependency bump; no changes to auth, locking, or install resolution logic.
Overview
Bumps embedded aube workspace crates from 1.39.0 to 1.40.0, which tag lifecycle script stdout/stderr as
InstallEvent::Outputwith codeAUBE_LIFECYCLE_SCRIPT_OUTPUT.In
apply_aube_event, those info events are printed viaSingleReport::printlnso mise’s progress layer (clx) can redraw safely alongside active install jobs. Other informational aube output stays at debug; warnings and errors are unchanged.Adds unit/integration tests that assert lifecycle lines reach the progress report and that non-lifecycle info is not printed.
Reviewed by Cursor Bugbot for commit 1bcf9de. Bugbot is set up for automated code reviews on this repo. Configure here.