Repository navigation
chore: integrate hk agent workflow - #11936
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (2)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe repository now configures the Changeshk workflow
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR upgrades hk to 1.55.0 and integrates its agent-oriented workflow.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code defect identified. The hk schema migration, MCP configuration, workflow documentation, and lockfile update are internally consistent, and the investigated edge cases did not expose a current reachable failure. Important Files Changed
Reviews (1): Last reviewed commit: "chore: integrate hk agent workflow" | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Summary
hk.pklto the v1.55 schema and classify custom commands as read or writeWhy
hk 1.55.0 adds its agent-native workflow, including MCP support, structured output, exact file scoping, and effect-aware safe execution. The existing custom command strings were classified as unknown, so
--safecould not run until the project configuration declared their effects.Validation
hk validatehk run check --safe --format json --files0-from -mise run lint-fixgit diff --checkAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Low Risk
Dev-tooling and hook config only; no runtime mise behavior changes, though misclassified write effects could affect what
--safeallows agents to run.Overview
Upgrades pinned hk to 1.55.0 in
mise.lockand retargetshk.pklto the v1.55 config package so lint hooks use the new schema.Every custom linter command in
hk.pklis wrapped inCommandSpecwith explicitreadorwriteeffects (including fix steps and checks likecargo-check), andshellcheck/shfmtsetmatch_any = nullso behavior matches the updated builtins. That unblockshk run check --safefor agent-driven linting..codex/config.tomlregisters the project-localhk mcpserver for Codex.AGENTS.mddocuments preferring that MCP path, safe JSON/JSONL output, and scoping with--files0-from/--cd.Reviewed by Cursor Bugbot for commit 5446fa6. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Documentation
Chores