Repository navigation
feat(task): add --all to run picker - #11920
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (3)
📝 WalkthroughWalkthroughThe PR adds ChangesMonorepo-wide task selection
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant Developer
participant mise_run
participant get_task_lists
participant prompt_for_task
participant MonorepoTasks
Developer->>mise_run: invoke --all
mise_run->>get_task_lists: pass all=true
get_task_lists->>prompt_for_task: pass Config and all
prompt_for_task->>MonorepoTasks: load with TaskLoadContext::all()
MonorepoTasks-->>prompt_for_task: return monorepo task choices
prompt_for_task-->>Developer: show interactive selector
Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryAdds
Confidence Score: 5/5The pull request appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "chore(ci): fix run flag ordering" | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 8c9fc06. Configure here.
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
e2e/tasks/test_task_run_all_picker (1)
29-32: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winVerify that the selector runs only the chosen task.
The assertion only checks for
child task ran. An implementation that ignores the arrow input and runs both tasks would pass. Also assert thatdefault task ranis absent.Proposed assertion
-if [[ $output != *"child task ran"* ]]; then +if [[ $output != *"child task ran"* || $output == *"default task ran"* ]]; then🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@e2e/tasks/test_task_run_all_picker` around lines 29 - 32, Strengthen the assertions in the task selector test by verifying that the output does not contain “default task ran” after confirming it contains “child task ran”. Keep the existing child-task assertion and fail the test when the unselected default task also executes.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@e2e/tasks/test_task_run_all_picker`:
- Around line 29-32: Strengthen the assertions in the task selector test by
verifying that the output does not contain “default task ran” after confirming
it contains “child task ran”. Keep the existing child-task assertion and fail
the test when the unselected default task also executes.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 6346af30-8ee2-466e-8598-6f99f4411b96
📒 Files selected for processing (8)
docs/cli/run.mddocs/cli/tasks/run.mde2e/tasks/test_task_run_all_pickermise.usage.kdlsrc/cli/bootstrap.rssrc/cli/mod.rssrc/cli/run.rssrc/task/task_list.rs
🚧 Files skipped from review as they are similar to previous changes (6)
- src/cli/bootstrap.rs
- docs/cli/run.md
- mise.usage.kdl
- docs/cli/tasks/run.md
- src/cli/mod.rs
- src/task/task_list.rs
Summary
mise run --allto load every monorepo task in the interactive selectorWhy
The interactive
mise runpicker always used hierarchy-scoped task discovery, even thoughmise tasks ls --allalready supported loading sibling-project tasks. This makes the picker use the existingTaskLoadContext::all()path when--allis requested.Closes the feature gap discussed in #9349.
Validation
mise run test:e2e e2e/tasks/test_task_run_all_pickermise run render:usagemise run lint-fixAI-assisted — Tool: Codex; model: OpenAI/GPT-5; version: unavailable.
Note
Low Risk
Additive CLI flag for interactive monorepo task selection; default picker behavior is unchanged and conflicts prevent unsafe combinations.
Overview
Adds
mise run --allto open the interactive task picker with tasks from the entire monorepo, matching the existingtasks ls --allload path viaTaskLoadContext::all().The default picker stays hierarchy-scoped.
--allconflicts with an explicit task name and--affected. Makingtaskoptional (still defaulting todefaultwhen omitted) enables that conflict check.Includes an e2e test that selects a sibling-project task through the picker, plus regenerated CLI docs.
Reviewed by Cursor Bugbot for commit 3346361. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
--alloption tomise runandmise tasks run.defaultis selected automatically.--allcombinations.