Repository navigation
fix(release): update cache dependencies before version resolution - #11860
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe release script adds verified path dependency version updates. Package versioning now applies this logic to ChangesWorkspace dependency versioning
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Possibly related PRs
Suggested reviewers: Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR updates workspace path dependency constraints before Cargo resolves release version bumps, including the dependency from
Confidence Score: 5/5The PR appears safe to merge with no actionable correctness or security issues identified. The helper matches every current targeted dependency declaration, updates all workspace dependents that require coordinated constraints, and runs before Cargo performs offline version resolution. Important Files Changed
Reviews (1): Last reviewed commit: "fix(release): update cache dependencies ..." | Re-trigger Greptile |
Summary
mise-cache-rustccompatible whenmise-cache-coreis bumpedRoot cause
Release run 31449959861 bumped
mise-cache-corefrom 0.1.0 to 2026.8.0, thencargo update --offlinefailed becausemise-cache-rustcstill requiredmise-cache-core = "^0.1".Validation
bash -n xtasks/release-plzmise run lint-fixgit diff --checkAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Low Risk
Changes are confined to the CI release script with validation noted in the PR; no runtime product code paths.
Overview
Release bumps now refresh workspace path dependency
versionfields in the right manifests beforecargo update --offline, so Cargo can resolve calver jumps without stale semver constraints.A new
set_path_dependency_versionhelper (sed + awk verification) replaces the ad hocmise-interactive-config-only logic.set_package_versionuses acaseon the bumped crate:mise-cache-coreupdates rootCargo.tomlandcrates/mise-cache-rustc/Cargo.toml;mise-cache-rustcandmise-interactive-configupdate the root workspace entry.Reviewed by Cursor Bugbot for commit dfaf5b2. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit