Skip to content

fix(release): update cache dependencies before version resolution - #11860

Merged
jdx merged 1 commit into
mainfrom
codex/fix-cache-release-order
Aug 11, 2026
Merged

jdx merged 1 commit into
mainfrom
codex/fix-cache-release-order

Conversation

@jdx

@jdx jdx commented Aug 11, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • update workspace path dependency versions before Cargo resolves release bumps
  • keep mise-cache-rustc compatible when mise-cache-core is bumped
  • apply the same checked helper to the root cache and interactive-config dependencies

Root cause

Release run 31449959861 bumped mise-cache-core from 0.1.0 to 2026.8.0, then cargo update --offline failed because mise-cache-rustc still required mise-cache-core = "^0.1".

Validation

  • exercised the complete core 0.1.0 → 2026.8.0 and rustc 0.1.0 → 2026.8.0 transition in a disposable worktree
  • verified both offline Cargo updates and workspace metadata
  • bash -n xtasks/release-plz
  • mise run lint-fix
  • git diff --check

AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.


Note

Low Risk
Changes are confined to the CI release script with validation noted in the PR; no runtime product code paths.

Overview
Release bumps now refresh workspace path dependency version fields in the right manifests before cargo update --offline, so Cargo can resolve calver jumps without stale semver constraints.

A new set_path_dependency_version helper (sed + awk verification) replaces the ad hoc mise-interactive-config-only logic. set_package_version uses a case on the bumped crate: mise-cache-core updates root Cargo.toml and crates/mise-cache-rustc/Cargo.toml; mise-cache-rustc and mise-interactive-config update the root workspace entry.

Reviewed by Cursor Bugbot for commit dfaf5b2. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Bug Fixes
    • Improved version updates for workspace path dependencies.
    • Ensured dependency declarations are correctly updated and validated during package releases.

@coderabbitai

coderabbitai Bot commented Aug 11, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2515b46b-7e28-4370-b563-8d8bb53174b8

📥 Commits

Reviewing files that changed from the base of the PR and between 2161a91 and dfaf5b2.

📒 Files selected for processing (1)
  • xtasks/release-plz

📝 Walkthrough

Walkthrough

The release script adds verified path dependency version updates. Package versioning now applies this logic to mise-cache-core, mise-cache-rustc, and mise-interactive-config.

Changes

Workspace dependency versioning

Layer / File(s) Summary
Path dependency update helper
xtasks/release-plz
Adds set_path_dependency_version to update and verify inline path dependency versions.
Package version integration
xtasks/release-plz
Uses the helper for three workspace dependencies and updates both relevant manifests for mise-cache-core.

Estimated code review effort: 3 (Moderate) | ~15–30 minutes

Possibly related PRs

  • jdx/mise#11323: Extends the earlier mise-interactive-config path dependency handling.
  • jdx/mise#11856: Also updates and verifies workspace path dependencies in set_package_version.

Suggested reviewers: risu729

Poem

A rabbit checks each version line,
With paths aligned in neat design.
Core and Rustc join the tune,
Interactive config follows soon.
The release script hops, precise and bright.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx merged commit 17e9db8 into main Aug 11, 2026
22 of 25 checks passed
@jdx
jdx deleted the codex/fix-cache-release-order branch August 11, 2026 01:49
@greptile-apps

greptile-apps Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

The PR updates workspace path dependency constraints before Cargo resolves release version bumps, including the dependency from mise-cache-rustc to mise-cache-core.

  • Adds a checked helper for updating inline path dependency versions.
  • Applies coordinated updates for the root cache dependencies, the cache crate relationship, and mise-interactive-config.

Confidence Score: 5/5

The PR appears safe to merge with no actionable correctness or security issues identified.

The helper matches every current targeted dependency declaration, updates all workspace dependents that require coordinated constraints, and runs before Cargo performs offline version resolution.

Important Files Changed

Filename Overview
xtasks/release-plz Adds and correctly applies a validated manifest-edit helper before offline Cargo resolution; no actionable defect was identified.

Reviews (1): Last reviewed commit: "fix(release): update cache dependencies ..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant