Skip to content

registry: add zk (aqua:zk-org/zk) - #11827

Merged
jdx merged 1 commit into
jdx:mainfrom
l0con0x2a:registry/zk
Aug 10, 2026
Merged

jdx merged 1 commit into
jdx:mainfrom
l0con0x2a:registry/zk

Conversation

@l0con0x2a

@l0con0x2a l0con0x2a commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Add zk to the mise registry using the existing Aqua Registry package aqua:zk-org/zk.

zk is a plain text note-taking assistant.

Popularity

  • GitHub: 2,752 stars, 186 forks
  • Aqua Registry: zk-org/zk is already registered

Testing

  • cargo run -- test-tool zk --raw
  • mise run pre-commit
  • git diff --check

Summary by CodeRabbit

  • New Features
    • Added support for the zk backend.
    • Enabled reliable version detection using semantic version ordering.
    • Added automated version validation to improve compatibility and backend discovery.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2fd29014-543c-471d-b81a-2ef2e36c6973

📥 Commits

Reviewing files that changed from the base of the PR and between f1ef8f1 and 949f966.

📒 Files selected for processing (1)
  • registry/zk.toml
🚧 Files skipped from review as they are similar to previous changes (1)
  • registry/zk.toml

📝 Walkthrough

Walkthrough

The change adds registry metadata for the aqua:zk-org/zk backend. It defines the zk binary, description, semantic-version ordering, and version validation command.

Changes

zk Registry Backend

Layer / File(s) Summary
zk backend metadata
registry/zk.toml
Adds metadata for the zk backend, including its binary, description, semantic-version ordering, and zk --version validation command.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Possibly related PRs

  • jdx/mise#11390: Adds registry metadata and a version test for a different tool.

Poem

A rabbit checks the registry bright,
zk metadata sits just right.
The binary is named,
Its version is framed,
Semantic order keeps paths light.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes adding the zk tool to the registry.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@registry/zk.toml`:
- Line 9: Connect the registry configuration key version_order to runtime
behavior by adding the corresponding field and parsing in RegistryTool and
applying semantic-version ordering in the registry implementation; otherwise
remove version_order from the configuration until supported.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: b0d9375f-6050-453b-b25e-419cd1bf4c2e

📥 Commits

Reviewing files that changed from the base of the PR and between f1ef8f1 and 094dba7.

📒 Files selected for processing (1)
  • registry/zk.toml

Comment thread registry/zk.toml Resolved
@greptile-apps

greptile-apps Bot commented Aug 10, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

Adds zk, a plain-text note-taking assistant, to the mise registry through its existing Aqua package.

  • Maps the zk short name to aqua:zk-org/zk.
  • Declares the installed binary and a templated version check.
  • Uses semantic-version ordering.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
registry/zk.toml Adds a well-formed Aqua-backed registry entry for zk with binary, description, version test, and semantic ordering metadata.

Reviews (5): Last reviewed commit: "registry: add zk (aqua:zk-org/zk)" | Re-trigger Greptile

Comment thread registry/zk.toml Resolved
Comment thread registry/zk.toml Resolved

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 094dba777c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread registry/zk.toml Resolved
@l0con0x2a l0con0x2a changed the title registory: add zk (aqua:zk-org/zk) registry: add zk (aqua:zk-org/zk) Aug 10, 2026
greptile-apps[bot]
greptile-apps Bot previously approved these changes Aug 10, 2026
@greptile-apps
greptile-apps Bot dismissed their stale review August 10, 2026 03:39

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

greptile-apps[bot]
greptile-apps Bot previously approved these changes Aug 10, 2026
@greptile-apps
greptile-apps Bot dismissed their stale review August 10, 2026 03:47

Dismissed because a newer commit was pushed; Greptile will re-review the current head.

@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Note

GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer.

@jdx
jdx merged commit 06d601c into jdx:main Aug 10, 2026
31 checks passed
german-molins added a commit to german-molins/dotfiles that referenced this pull request Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants