Repository navigation
chore(deps): update aube to v1.38.0 - #11759
Conversation
📝 WalkthroughWalkthroughThe PR updates Aube to version ChangesAube embedded install storage
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Greptile SummaryThe PR upgrades the embedded
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (3): Last reviewed commit: "fix(npm): isolate embedded aube storage ..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
8821972 to
4b9b830
Compare
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
## Summary - install a known deprecated npm package through mise's embedded aube path - verify aube's warning arrives through mise's output pipeline - guard against suggesting the nonexistent `mise deprecations` command ## Why aube v1.38.0 routes install-time deprecation warnings through structured embedder events and suppresses standalone aube command hints for embedded hosts. This regression test exercises the full mise integration boundary, including the progress renderer that the old direct stderr write corrupted. Regression coverage for #11742 and aubepkg/aube#1236. ## Stack Depends on #11760, which depends on the aube v1.38.0 bump in #11759. ## Validation - `mise run test:e2e e2e/backend/test_npm_aube` *AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.* <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only change with no production or runtime behavior impact. > > **Overview** > Extends **`e2e/backend/test_npm_aube`** with integration checks for install-time deprecation warnings on the embedded aube path. > > After **`mise install npm:inflight@1.0.6`**, the test captures combined stdout/stderr and asserts the output includes **`deprecated inflight@1.0.6`** and does **not** mention **`mise deprecations`**, so warnings go through mise’s renderer without bogus CLI hints. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit 8d66348. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Summary
aubeandaube-registrycrates to v1.38.0Cargo.lockWhy
aube v1.38.0 publishes the embedder storage overrides from aubepkg/aube#1239 and structured deprecation output from aubepkg/aube#1236. Keeping the dependency bump separate makes the follow-up mise integration changes easier to review.
Upstream release: aubepkg/aube#1202
Validation
cargo checkAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Medium Risk
Changes where embedded aube keeps packuments and file store (existing global aube data may be re-fetched); install behavior otherwise stays on the same per-tool layout and lockfile names.
Overview
Bumps embedded
aube/aube-registryto 1.38.0 (lockfile refresh, includingusage-lib5.0 and transitive updates).Embedded
npm:installs now callaube::embed::add_with_overrideswith mise-owned$MISE_CACHE_DIR/npm/aube/cacheand.../store,use_global_virtual_store: false, so regenerable aube state is prunable viamise cache prune npminstead of relying on aube’s global virtual store. Per-tool installs still land in the tool prefix (node_modules, lockfile).aube_hostdocs/tests now stress config name compatibility (lockfile,aube.allowBuilds) rather than claiming the host profile pins all on-disk layout. E2e and a unit test lock in the new cache/store paths.Reviewed by Cursor Bugbot for commit 4b9b830. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit