Repository navigation
test(task): add remote cache compatibility suite - #11629
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR adds an executable protocol-v1 compatibility suite for self-hosted task-cache servers and marks the corresponding parity item complete.
Confidence Score: 4/5The PR should not merge until the outstanding immutable-blob compatibility coverage is completed. The suite never retries an identical blob upload or sends mismatched bytes under a declared digest, allowing servers that violate immutable blob-write semantics to pass the advertised compatibility checks. Files Needing Attention: scripts/task-cache-remote-compat.sh Important Files Changed
Reviews (16): Last reviewed commit: "test(task): validate content-addressed c..." | Re-trigger Greptile |
c8ceff1 to
200996c
Compare
200996c to
9c346a5
Compare
9c346a5 to
45d533c
Compare
45d533c to
5676bce
Compare
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
5676bce to
d86df80
Compare
376212d to
809b726
Compare
809b726 to
c79fc1e
Compare
c79fc1e to
2b51a16
Compare
2b51a16 to
ef4accb
Compare
ef4accb to
695b368
Compare
695b368 to
5ee51bd
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 5ee51bd. Configure here.
0fc5cc4 to
df5bdfc
Compare
df5bdfc to
cac23fc
Compare
## Summary - add an executable protocol-v1 compatibility suite for self-hosted remote cache servers - cover discovery, byte-preserving uploads/downloads, namespace isolation, immutable conflicts, and deletion - document bearer-authenticated and environment-driven suite usage - specify idempotent manifest-first deletion behavior in the protocol ## Tests - `shfmt -d scripts/task-cache-remote-compat.sh` - `shellcheck scripts/task-cache-remote-compat.sh` - `markdownlint-cli2 docs/tasks/remote-cache-protocol.md TASK_CACHE_PARITY.md` - `prettier --check docs/tasks/remote-cache-protocol.md TASK_CACHE_PARITY.md` *AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.* <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only shell script and documentation checkbox; no runtime cache client or server behavior changes in this diff. > > **Overview** > Adds **`scripts/task-cache-remote-compat.sh`**, an executable conformance harness operators can run against a self-hosted remote cache using a disposable namespace (CLI args or `MISE_TASK_CACHE_COMPAT_*` env vars, optional bearer token). > > The script exercises **protocol v1** end-to-end: `/v1/status` and `/v1/capabilities`, `blobs:missing`, immutable blob uploads with `If-None-Match: *`, action-result commit (201 then 204 on replay), result fetch, artifact download (including HTTPS redirect handling), **namespace isolation** (403/404), and **412** when overwriting a blob without the immutable precondition. > > **`TASK_CACHE_PARITY.md`** marks the remote-cache tracker item “Provide a self-hosting reference or compatibility test suite” as complete. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit cac23fc. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->

Summary
Tests
shfmt -d scripts/task-cache-remote-compat.shshellcheck scripts/task-cache-remote-compat.shmarkdownlint-cli2 docs/tasks/remote-cache-protocol.md TASK_CACHE_PARITY.mdprettier --check docs/tasks/remote-cache-protocol.md TASK_CACHE_PARITY.mdAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Low Risk
Test-only shell script and documentation checkbox; no runtime cache client or server behavior changes in this diff.
Overview
Adds
scripts/task-cache-remote-compat.sh, an executable conformance harness operators can run against a self-hosted remote cache using a disposable namespace (CLI args orMISE_TASK_CACHE_COMPAT_*env vars, optional bearer token).The script exercises protocol v1 end-to-end:
/v1/statusand/v1/capabilities,blobs:missing, immutable blob uploads withIf-None-Match: *, action-result commit (201 then 204 on replay), result fetch, artifact download (including HTTPS redirect handling), namespace isolation (403/404), and 412 when overwriting a blob without the immutable precondition.TASK_CACHE_PARITY.mdmarks the remote-cache tracker item “Provide a self-hosting reference or compatibility test suite” as complete.Reviewed by Cursor Bugbot for commit cac23fc. Bugbot is set up for automated code reviews on this repo. Configure here.