Repository navigation
feat(task): authenticate remote cache requests - #11625
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR adds global-only Bearer authentication for remote task-cache requests while redacting the credential from settings diagnostics and output.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported credential disclosure and unauthenticated HTTP compatibility issues are fixed in the current code. Important Files Changed
Reviews (12): Last reviewed commit: "fix(config): redact remote cache token f..." | Re-trigger Greptile |
be8ad44 to
7934540
Compare
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
7934540 to
9bfcfce
Compare
9bfcfce to
bc0f377
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit bc0f377. Configure here.
bc0f377 to
63383df
Compare
63383df to
a087b6f
Compare
20a4bf8 to
80485e5
Compare
80485e5 to
c4bd6b4
Compare
c4bd6b4 to
420ae5c
Compare
420ae5c to
de646ab
Compare
## Summary - add a global-only experimental Bearer token setting for remote task cache authentication - attach the token to every remote request with a sensitive `Authorization` header - retain explicit repository or organization namespace isolation from the preceding stack layer ## Tests - `cargo test task_cache_store::tests` - `cargo clippy --workspace --all-features --all-targets -- -D warnings` - `mise run lint-fix` *AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.* <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Medium Risk** > Introduces credential handling and transport policy for remote cache traffic; mitigations include global-only config, HTTPS enforcement when a token is set, sensitive header marking, and redaction in diagnostics. > > **Overview** > Adds **Bearer token authentication** for the experimental remote task cache via a new global-only `task.cache_remote_token` setting (`MISE_TASK_CACHE_REMOTE_TOKEN`), wired from settings into `RemoteTaskCacheConfig` and sent on every HTTP cache request as a sensitive `Authorization` header. > > **Transport rules** are tightened: credentialed requests require **HTTPS** except on loopback; unauthenticated non-loopback HTTP is allowed only with an explicit transit-risk warning. The remote cache protocol doc and JSON schema/settings docs are updated accordingly, and the parity tracker marks authentication/namespaces as done. > > **Credential hygiene**: remote cache tokens are **redacted** in debug settings dumps and in `as_dict` / partial settings tables so they do not leak in logs or exported config. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit de646ab. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->

Summary
AuthorizationheaderTests
cargo test task_cache_store::testscargo clippy --workspace --all-features --all-targets -- -D warningsmise run lint-fixAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Medium Risk
Introduces credential handling and transport policy for remote cache traffic; mitigations include global-only config, HTTPS enforcement when a token is set, sensitive header marking, and redaction in diagnostics.
Overview
Adds Bearer token authentication for the experimental remote task cache via a new global-only
task.cache_remote_tokensetting (MISE_TASK_CACHE_REMOTE_TOKEN), wired from settings intoRemoteTaskCacheConfigand sent on every HTTP cache request as a sensitiveAuthorizationheader.Transport rules are tightened: credentialed requests require HTTPS except on loopback; unauthenticated non-loopback HTTP is allowed only with an explicit transit-risk warning. The remote cache protocol doc and JSON schema/settings docs are updated accordingly, and the parity tracker marks authentication/namespaces as done.
Credential hygiene: remote cache tokens are redacted in debug settings dumps and in
as_dict/ partial settings tables so they do not leak in logs or exported config.Reviewed by Cursor Bugbot for commit de646ab. Bugbot is set up for automated code reviews on this repo. Configure here.