Repository navigation
test(task): cover task cache restore on windows - #11612
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds Windows end-to-end coverage for restoring task artifacts and captured output from cache, then marks the corresponding parity tracker item complete.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported environment leak is fixed by saving and restoring each overridden value. Important Files Changed
Reviews (8): Last reviewed commit: "test(task): cover task cache restore on ..." | Re-trigger Greptile |
c736666 to
26f4577
Compare
26f4577 to
bddc11d
Compare
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
bddc11d to
c63aa73
Compare
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
c63aa73 to
f99f3b1
Compare
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
f99f3b1 to
c63aa73
Compare
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
c63aa73 to
72782f6
Compare
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
72782f6 to
d8f0805
Compare
Dismissed because a newer commit was pushed; Greptile will re-review the current head.
## Summary - add a Windows Pester test for task artifact cache restoration - verify the first run publishes one manifest/archive pair - remove declared outputs and prove the second run restores files, stdout, and stderr without executing again - complete the Windows restore coverage tracker item ## Validation - `mise run lint-fix` - Windows execution is covered by the `windows-e2e` GitHub Actions job; PowerShell is not available on the local Linux host *AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.* <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Test-only and tracker doc update; no changes to cache or task runtime behavior. > > **Overview** > Adds **Windows end-to-end coverage** for experimental task artifact cache restore via a new Pester suite in `e2e-win/task_artifact_cache.Tests.ps1`. > > The test spins up an isolated `mise.toml` with cache enabled, runs a `pwsh` `build` task that writes `dist/` and appends to `runs.txt`, then asserts the first run emits stdout/stderr and creates exactly one manifest (`.json`) and archive (`.tar.zst`) under `task-artifacts/v2`. After deleting `dist`, a second `mise run build` must report a cache restore, replay captured output, restore `dist/result.txt`, and **not** run the task again (`runs.txt` still has one line). > > Marks **“Test restore behavior on Windows”** complete in `TASK_CACHE_PARITY.md`. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d8f0805. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Summary
Validation
mise run lint-fixwindows-e2eGitHub Actions job; PowerShell is not available on the local Linux hostAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Low Risk
Test-only and tracker doc update; no changes to cache or task runtime behavior.
Overview
Adds Windows end-to-end coverage for experimental task artifact cache restore via a new Pester suite in
e2e-win/task_artifact_cache.Tests.ps1.The test spins up an isolated
mise.tomlwith cache enabled, runs apwshbuildtask that writesdist/and appends toruns.txt, then asserts the first run emits stdout/stderr and creates exactly one manifest (.json) and archive (.tar.zst) undertask-artifacts/v2. After deletingdist, a secondmise run buildmust report a cache restore, replay captured output, restoredist/result.txt, and not run the task again (runs.txtstill has one line).Marks “Test restore behavior on Windows” complete in
TASK_CACHE_PARITY.md.Reviewed by Cursor Bugbot for commit d8f0805. Bugbot is set up for automated code reviews on this repo. Configure here.