Repository navigation
fix(schema): publish schemas with documentation - #11596
Conversation
📝 WalkthroughWalkthroughThe documentation build now publishes five selected schema files under ChangesSchema asset publishing
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR publishes five repository-owned JSON schemas as stable VitePress build assets and ensures schema-only changes trigger documentation builds.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "fix(schema): deploy schema-only changes" | Re-trigger Greptile |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f60b074. Configure here.
There was a problem hiding this comment.
🧹 Nitpick comments (1)
docs/.vitepress/config.ts (1)
114-127: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winRestrict this plugin to build mode.
devDependencies.vitepressis1.6.4, and Vite 5 exposesthis.emitFile()in serve mode only as a no-op with a warning. If the plugin runs duringvitepress dev, it writes nothing toschema/and logs an error.Proposed fix
{ name: "mise-schema-assets", + apply: "build", buildStart() {If local development must serve
/schema/*.json, add a separate dev-server handler.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/.vitepress/config.ts` around lines 114 - 127, Restrict the `mise-schema-assets` plugin’s `buildStart` behavior to VitePress build mode by checking the current command before calling `this.emitFile()`. Preserve schema asset emission during builds, and avoid running this emission logic during `vitepress dev`; add a separate dev-server handler only if development must serve `/schema/*.json`.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@docs/.vitepress/config.ts`:
- Around line 114-127: Restrict the `mise-schema-assets` plugin’s `buildStart`
behavior to VitePress build mode by checking the current command before calling
`this.emitFile()`. Preserve schema asset emission during builds, and avoid
running this emission logic during `vitepress dev`; add a separate dev-server
handler only if development must serve `/schema/*.json`.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Central YAML (base), Organization UI (inherited)
Review profile: CHILL
Plan: Pro Plus
Run ID: 12a82b1d-3963-45ff-8730-660f19440ecc
📒 Files selected for processing (1)
docs/.vitepress/config.ts
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Dismissed because a newer commit was pushed; Greptile will re-review the current head.

Summary
$idvalues as VitePress build assets under/schema/schema/files as the single source of truthWhy
mise-settings.jsonandmise-registry-tool.jsonadvertise public schema URLs but were never copied by the release uploader, so those URLs return 404. Emitting the schemas during the docs build makes schema availability follow documentation deployments instead of mise releases.Validation
mise run docs:buildschema/AI-assisted — Tool: Codex; model: openai/unavailable; version: unavailable.
Note
Low Risk
Static asset emission and CI path filters only; no runtime, auth, or data-handling changes.
Overview
Fixes broken public schema URLs by shipping the five JSON schemas (
mise.json, plugin, task, settings, registry-tool) as VitePress build assets at/schema/, copied byte-for-byte from the repo’sschema/directory.A custom Vite plugin (
mise-schema-assets) runs at build start andemitFiles each schema so schema availability tracks docs deployments instead of the release uploader.The docs GitHub workflow now includes
schema/**in push/PR path filters so schema edits trigger a docs rebuild and redeploy.Reviewed by Cursor Bugbot for commit 392b8fb. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
schema/path.