Repository navigation
fix(registry): gate baked registry accessor in release builds - #11594
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe baked-registry accessor in ChangesDebug registry compilation
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR conditionally compiles the dedicated baked-registry accessor only in debug builds, matching its sole consumer and removing a release-build dead-code warning.
Confidence Score: 5/5The PR appears safe to merge because the accessor and all of its consumers share the same debug-only compilation boundary. The only call to Important Files Changed
Reviews (1): Last reviewed commit: "fix(registry): gate baked registry acces..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Summary
baked_registry()only when debug assertions are enabledrender-helpcommandRoot cause
Release builds exclude
render-helpbut still compiled its dedicated registry accessor, causing adead_codewarning.Impact
Release builds no longer emit the unused
baked_registrywarning. Runtime registry behavior is unchanged.Validation
mise run lint-fixcargo check --release --all-featurescargo check --all-featuresgit diff --checkAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Low Risk
Compile-time cfg only; no change to release runtime registry behavior.
Overview
Adds
#[cfg(debug_assertions)]aroundbaked_registry()so release builds no longer compile that helper.The function is only used by the debug-only
render-helpflow (idiomatic version files table).REGISTRYandBAKED_REGISTRYare unchanged; this is a compile-time cleanup to silencedead_codeincargo check --release.Reviewed by Cursor Bugbot for commit 02302df. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit