Repository navigation
feat(task): explain affected task selection - #11591
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR adds deterministic explanations for affected project and task selection while preserving the existing selection behavior.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported output-escaping and dependency-cause completeness issues are fixed in the current code. Important Files Changed
Reviews (7): Last reviewed commit: "feat(task): explain affected task select..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
9abfedf to
3555061
Compare
3555061 to
d6efd44
Compare
d6efd44 to
a57b773
Compare
a57b773 to
2827e25
Compare
2827e25 to
0e54aa2
Compare
0e54aa2 to
ba3988e
Compare
ba3988e to
b6bb872
Compare
Summary
--affected-explainto show why workspace projects and task-pattern matches were selectedTesting
target/debug/mise run lint-fixcargo clippy --quiet --workspace --all-features --all-targets -- -D warningstarget/debug/mise run test:e2e e2e/tasks/test_task_affectedcargo test --quiet task::workspace::tests::affected_project_reasons_distinguish_changes_and_dependentsshellcheck -x e2e/tasks/test_task_affectedshfmt -d e2e/tasks/test_task_affectedtarget/debug/mise run render:usageStacked on #11590.
AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Low Risk
Diagnostics-only CLI and graph API extension; affected selection behavior is unchanged aside from richer internal reasoning and explain output.
Overview
Adds
--affected-explaintomise run(requires--affected) so runs print why workspace projects and matching task patterns were selected, without changing which tasks execute.Affected analysis now keeps structured reasons per project via
AffectedProjectReasonandAffectedProjects, withaffected_projects_for_changesrecording changed paths, workspace-global paths, provider-attributed lockfiles, and reverse dependents (including multiple dependency causes). Human-readable output lists revisions, each project’s causes, and affected tasks; paths and labels useescape_debugfor safer terminal output.Docs, usage/man pages, the parity tracker milestone, unit tests, and e2e coverage for path/lockfile explanations are updated accordingly.
Reviewed by Cursor Bugbot for commit b6bb872. Bugbot is set up for automated code reviews on this repo. Configure here.