Repository navigation
feat(task): include global inputs in affected projects - #11587
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesWorkspace impact analysis
Estimated code review effort: 3 (Moderate) | ~15–30 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThe PR adds workspace-graph logic for expanding changed paths into affected projects.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains; the previously reported parity-tracker issue is resolved because the affected-project/global-input item is currently unchecked. Important Files Changed
Reviews (2): Last reviewed commit: "docs(task): keep affected integration pe..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
4af14d4 to
abba875
Compare
abba875 to
3be0c00
Compare
Summary
Why
Changed-file ownership alone cannot safely narrow repository-wide configuration and shared inputs. This layer connects changed paths to affected project expansion while reusing the existing global-input contract instead of introducing parallel configuration.
Validation
AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Medium Risk
Affects which monorepo projects run on file changes; incorrect global-input matching could over- or under-run tasks, but logic reuses existing task source matchers and is covered by new tests.
Overview
Adds
affected_projects_for_pathsonWorkspaceProjectGraphso changed-file → affected-project expansion respects workspace-global inputs, not only per-project ownership.Changes under paths that match resolved
task_config.global_inputs(via existingbuild_source_matcher/is_sourcesemantics, including excludes) mark the whole workspace affected, even when the file lives inside a project root. Paths with no owning project do the same. Otherwise behavior stays the same: map paths to projects and expand throughaffected_projects(reverse-dependency closure).Unit tests cover unowned paths, global patterns, ordinary scoped changes, and exclusion patterns that keep changes local to one project.
Reviewed by Cursor Bugbot for commit b3b4052. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit