Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryCentralizes task execution parameters into dedicated context structs.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "refactor(task): centralize execution con..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
5baf366 to
b1613b8
Compare
Stack created with GitHub Stacks CLI • Give Feedback 💬
Note
Low Risk
Mechanical signature refactor in the task executor with no intended logic changes; risk is limited to accidental parameter wiring mistakes during review.
Overview
Refactors task execution plumbing in
task_executor.rsby grouping long parameter lists into three internal context structs, without changing runtime behavior.TaskExecContextbundles task, env, output prefix, optional artifact output capture, and interruption policy. It is built once inrun_task_schedand passed throughexec_file→exec→exec_program, plusexec_scriptand the ETXTBUSY retry path, replacing repeated per-method argument lists.TaskRunEntriesContextcarries config, the shared exec context, task env, scheduler channel, runtime lock guard, completion state, and semaphore/permit forexec_task_run_entries.TaskInjectionContextgroups config, env, scheduler, completion state, and interruption flag forinject_and_waitwhen run entries invoke nested tasks or task groups.Several
#[allow(clippy::too_many_arguments)]attributes are removed as a result.Reviewed by Cursor Bugbot for commit b1613b8. Bugbot is set up for automated code reviews on this repo. Configure here.