Skip to content

chore(lint): remove stale template exclusions - #11526

Merged
jdx merged 1 commit into
agent/refactor-clippy-backend-contextsfrom
agent/refactor-clippy-format-templates
Jul 30, 2026
Merged

jdx merged 1 commit into
agent/refactor-clippy-backend-contextsfrom
agent/refactor-clippy-format-templates

Conversation

@jdx

@jdx jdx commented Jul 30, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • remove nine file-wide clippy::literal_string_with_formatting_args exclusions
  • keep shell activation templates and progress rendering unchanged
  • confirm the current Clippy toolchain accepts every affected file without narrower suppressions

Validation

  • mise run lint
  • cargo clippy --bin mise --all-features -- -D warnings

This is a prerequisite cleanup in stack #11523; it targets #11525.

AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.


Note

Low Risk
Lint-only attribute removals with no behavioral changes; risk is limited to CI failing if Clippy regresses on those files.

Overview
Removes file-level #![allow(clippy::literal_string_with_formatting_args)] from nine modules (main, shell backends for bash/elvish/fish/nushell/pwsh/xonsh/zsh, and ui/progress_report). No runtime or template logic changes—only dropping suppressions that are no longer needed under the current Clippy toolchain.

Reviewed by Cursor Bugbot for commit 0be532a. Bugbot is set up for automated code reviews on this repo. Configure here.

@coderabbitai

coderabbitai Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 51735b1e-9c40-4b63-8038-11c36c2b2bc8

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes obsolete file-wide Clippy lint allowances without changing runtime behavior.

  • Removes clippy::literal_string_with_formatting_args allowances from the CLI entry point.
  • Removes the same allowances from seven shell implementations.
  • Removes the allowance from progress-report rendering.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
src/main.rs Removes an obsolete crate-level Clippy allowance; executable behavior is unchanged.
src/shell/bash.rs Removes an obsolete module-level Clippy allowance without changing Bash activation generation.
src/shell/elvish.rs Removes an obsolete module-level Clippy allowance without changing Elvish integration.
src/shell/fish.rs Removes an obsolete module-level Clippy allowance without changing Fish integration.
src/shell/nushell.rs Removes an obsolete module-level Clippy allowance without changing Nushell integration.
src/shell/pwsh.rs Removes an obsolete module-level Clippy allowance without changing PowerShell integration.
src/shell/xonsh.rs Removes an obsolete module-level Clippy allowance without changing Xonsh integration.
src/shell/zsh.rs Removes an obsolete module-level Clippy allowance without changing Zsh integration.
src/ui/progress_report.rs Removes an obsolete module-level Clippy allowance without changing progress rendering.

Reviews (2): Last reviewed commit: "chore(lint): remove stale template exclu..." | Re-trigger Greptile

@github-actions

github-actions Bot commented Jul 30, 2026 •

Copy link
Copy Markdown
Contributor

Instruction counts

benchmark trend instructions Δ wall (min) Δ
env ▂▂▁▆▆█▆██▇▇█▇▇█▆▃▆ 84,685,231 → 84,832,803 +0.17% 31.26 → 20.23ms -35.29%
hook-env ▄▃▃▇▇█▆███▇▇█▇▇▇▁▁ 87,057,131 → 87,045,259 -0.01% 26.40 → 22.41ms -15.14%
ls ▄▆▁▄▅█▃▅▅▇▅▆▆▆▆▄▅▄ 76,709,887 → 76,680,607 -0.04% 21.20 → 17.65ms -16.74%
registry ▇▅▃▇▇█▅█▇██▇█▆▆▅▁▂ 50,102,060 → 50,118,274 +0.03% 14.46 → 12.75ms -11.80%
startup ▇█▃▇▇▇▆▇▆▇▇▇▇▅▆▅▁▁ 15,941,779 → 15,937,317 -0.03% 11.62 → 9.10ms -21.73%

No instruction-count regression above 1%.

Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.

Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.

0be532a5c71c vs 1581ac06d458 · measured on the runner, not pushed to the history.

@jdx
jdx force-pushed the agent/refactor-clippy-format-templates branch from a689d42 to 0be532a Compare July 30, 2026 23:20
@jdx
jdx merged commit 3224735 into main Jul 30, 2026
37 of 55 checks passed
@jdx
jdx deleted the agent/refactor-clippy-format-templates branch July 30, 2026 23:56
jdx added a commit that referenced this pull request Jul 30, 2026
## Summary
- introduce `TaskRunContext` for scheduler state passed from the CLI
into the executor
- introduce `TaskCacheContext` for cache-key material
- remove three task scheduling/cache `clippy::too_many_arguments`
exclusions
- preserve task scheduling and artifact-cache behavior

## Validation
- `cargo clippy --workspace --all-targets --all-features -- -D warnings`
- `cargo test --all-features task::task_cache` (8 passed)
- `mise run test:e2e e2e/tasks/test_task_artifact_cache` (all matching
artifact-cache suites passed)

This is a prerequisite refactor in stack #11523; it targets #11526.

*AI-assisted — Tool: Codex; model: unavailable/unavailable; version:
unavailable.*

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Mechanical signature refactor with no logic changes; validated by
clippy and task cache tests.
> 
> **Overview**
> Introduces **`TaskRunContext`** so scheduler-related inputs (task,
config, `sched_tx`, completion/dependency state, semaphore, permit,
interruption flag) are passed as one struct from `mise run` through the
CLI wrapper into **`TaskExecutor::run_task_sched`**, replacing an
eight-argument signature.
> 
> Introduces **`TaskCacheContext`** so
**`TaskArtifactCacheBuilder::finish`** takes a single bundle of
cache-key inputs (task, config, toolset, env, dependency keys, command
inputs) instead of seven separate parameters.
> 
> Removes **`clippy::too_many_arguments`** suppressions on those two
call paths; scheduling and artifact-cache behavior is unchanged.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
fe4c17d. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant