Repository navigation
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryRemoves obsolete file-wide Clippy lint allowances without changing runtime behavior.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (2): Last reviewed commit: "chore(lint): remove stale template exclu..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
a689d42 to
0be532a
Compare
## Summary - introduce `TaskRunContext` for scheduler state passed from the CLI into the executor - introduce `TaskCacheContext` for cache-key material - remove three task scheduling/cache `clippy::too_many_arguments` exclusions - preserve task scheduling and artifact-cache behavior ## Validation - `cargo clippy --workspace --all-targets --all-features -- -D warnings` - `cargo test --all-features task::task_cache` (8 passed) - `mise run test:e2e e2e/tasks/test_task_artifact_cache` (all matching artifact-cache suites passed) This is a prerequisite refactor in stack #11523; it targets #11526. *AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.* <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Mechanical signature refactor with no logic changes; validated by clippy and task cache tests. > > **Overview** > Introduces **`TaskRunContext`** so scheduler-related inputs (task, config, `sched_tx`, completion/dependency state, semaphore, permit, interruption flag) are passed as one struct from `mise run` through the CLI wrapper into **`TaskExecutor::run_task_sched`**, replacing an eight-argument signature. > > Introduces **`TaskCacheContext`** so **`TaskArtifactCacheBuilder::finish`** takes a single bundle of cache-key inputs (task, config, toolset, env, dependency keys, command inputs) instead of seven separate parameters. > > Removes **`clippy::too_many_arguments`** suppressions on those two call paths; scheduling and artifact-cache behavior is unchanged. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit fe4c17d. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Summary
clippy::literal_string_with_formatting_argsexclusionsValidation
mise run lintcargo clippy --bin mise --all-features -- -D warningsThis is a prerequisite cleanup in stack #11523; it targets #11525.
AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Low Risk
Lint-only attribute removals with no behavioral changes; risk is limited to CI failing if Clippy regresses on those files.
Overview
Removes file-level
#![allow(clippy::literal_string_with_formatting_args)]from nine modules (main, shell backends for bash/elvish/fish/nushell/pwsh/xonsh/zsh, andui/progress_report). No runtime or template logic changes—only dropping suppressions that are no longer needed under the current Clippy toolchain.Reviewed by Cursor Bugbot for commit 0be532a. Bugbot is set up for automated code reviews on this repo. Configure here.