[jdx]

Summary

• return process statuses through ExitCode instead of calling the disallowed std::process::exit
• rename enum variants so they satisfy Clippy without suppressions
• normalize seccomp syscall constants across integer widths
• use an async-aware mutex in the brew test that holds a guard across await
• remove six targeted Clippy exclusions and fix the uncovered mise-shim warnings

Validation

• mise run lint
• cargo clippy --workspace --all-targets --all-features -- -D warnings
• cargo test -p mise-shim -p vfox --all-features (91 passed, 2 ignored)
• cargo test --all-features test_manager_repairs_linked_record_without_repouring

This is a prerequisite refactor in stack #11523; it targets #11522.

AI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.

---

Note

Low Risk
Behavioral change is mainly exit path ordering (destructors run before exit); exit codes and shell activation semantics are preserved.

Overview
This PR clears several Clippy suppressions by adjusting how binaries exit, renaming a few enums, and tightening test synchronization.

Process exit: mise, mise-shim, and vfox no longer call std::process::exit. They return ExitCode from main (with exit::status replacing exit::terminate), so teardown can run before the process ends.

Naming: ActivatePrelude variants drop the Env suffix (Set, Prepend, MovePrepend), and the completion CLI shell enum uses Powershell instead of PowerShell, removing enum_variant_names allowances.

Other: Seccomp rule keys use a small syscall_number helper instead of a conversion lint allow. Brew pour tests switch from std::sync::Mutex to tokio::sync::Mutex with blocking_lock / .await so the async test can hold the env lock across await without a clippy exception.

^{Reviewed by Cursor Bugbot for commit 479c2ea. Bugbot is set up for automated code reviews on this repo. Configure here.}

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 03e0bc83-a8f1-4e65-9610-ad510b7e431d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Exit status is truncated

When a Windows child returns a status outside 0..=255, casting the requested i32 status to u8 changes it before returning it to the OS, causing values such as 256 to be reported as success instead of preserving the child process failure.

Knowledge Base Used: CLI Dispatch Flow

[greptile-apps]

Greptile Summary

This refactor removes targeted Clippy exceptions while preserving command cleanup through returned exit codes.

• Replaces direct process termination with ExitCode returns in mise, mise-shim, and vfox.
• Renames shell and completion enum variants.
• Normalizes seccomp syscall integer widths.
• Uses Tokio's mutex in brew tests that hold the lock across awaits.

Confidence Score: 4/5

This PR is not yet safe to merge because both the main executable and standalone shim can misreport native Windows failure statuses.

The main exit helper still casts requested i32 statuses to u8, and the newly refactored shim independently applies the same narrowing to its child status; values such as 256 therefore become successful status 0.

Files Needing Attention: src/exit.rs and crates/mise-shim/src/main.rs

Important Files Changed

Filename	Overview
src/exit.rs	Replaces direct termination with an ExitCode conversion, but the previously reported status narrowing remains.
src/main.rs	Returns process statuses only after runtime shutdown and command-scope cleanup.
crates/mise-shim/src/main.rs	Refactors shim errors and child-status forwarding into a returned ExitCode, but narrows native Windows statuses.
crates/vfox/src/bin.rs	Returns standard success or failure codes instead of directly terminating.
src/sandbox/seccomp.rs	Normalizes architecture-dependent syscall constants through a generic i64 conversion.
src/shell/mod.rs	Renames activation prelude variants without changing their dispatch behavior.
src/system/packages/brew/pour.rs	Replaces the test environment lock with an async-aware Tokio mutex.

_{Reviews (2): Last reviewed commit: "refactor: remove targeted clippy excepti..." | Re-trigger Greptile}

[github-actions]

Instruction counts

benchmark	trend	instructions	Δ	wall (min)	Δ
env	▂▂▁▆▆█▆██▇▇█▇▇█▆▃▆	84,685,231 → 84,885,376	+0.24%	31.26 → 18.64ms	-40.38%
hook-env	▄▃▃▇▇█▆███▇▇█▇▇▇▁▁	87,057,131 → 87,094,864	+0.04%	26.40 → 19.97ms	-24.38%
ls	▄▆▁▄▅█▃▅▅▇▅▆▆▆▆▄▅▄	76,709,887 → 76,689,697	-0.03%	21.20 → 16.37ms	-22.76%
registry	▇▅▃▇▇█▅█▇██▇█▆▆▅▁▂	50,102,060 → 50,117,821	+0.03%	14.46 → 11.26ms	-22.13%
startup	▇█▃▇▇▇▆▆▆▇▇▆▇▅▆▅▁▁	15,941,779 → 15,939,182	-0.02%	11.62 → 8.34ms	-28.27%

No instruction-count regression above 1%.

_{Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run.}

_{Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.}

_{479c2ea04d49 vs 1581ac06d458 · measured on the runner, not pushed to the history.}

[cursor]

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit 479c2ea. Configure here.}

[cursor]

Windows child exit codes truncated

Medium Severity

Replacing std::process::exit with ExitCode::from(code as u8) narrows propagated statuses to eight bits. On Windows, std::process::exit previously forwarded the full i32 from mise exec and shims; values above 255 (or wrapped negatives) can now report the wrong process status, including mapping some failures to 0.

Additional Locations (1)

• crates/mise-shim/src/main.rs#L28-L29

 

^{Reviewed by Cursor Bugbot for commit 479c2ea. Configure here.}

[greptile-apps]

Shim exit status is truncated

When a Windows tool launched through an executable mise shim returns a status outside 0..=255, casting the status to u8 changes it before forwarding it. A status of 256 therefore becomes 0, causing the failed shimmed command to be reported as successful.

Knowledge Base Used: Shims