Repository navigation
test(system): avoid flaky GNU mirror in brew source e2e - #11509
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe slow GNU ChangesGNU source installation test
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR stabilizes the slow Homebrew source-build end-to-end test.
Confidence Score: 5/5The PR appears safe to merge with no actionable defects identified. The replacement matches the GNU hello source URL used by the Homebrew source-download path, rewrites it to the intended canonical archive host, and leaves SHA-256 verification intact. Important Files Changed
Reviews (1): Last reviewed commit: "test(system): avoid flaky GNU mirror in ..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Summary
Why
ftpmirror.gnu.orgintermittently returns HTTP 502 responses, causing the test to fail before it exercises mise's source-build pipeline. The canonicalftp.gnu.orgarchive serves the same checksum-verified tarball more reliably.Validation
mise run test:e2e test_system_install_brew_source_slowmise run lint-fixAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Low Risk
Test-only URL rewrite for e2e; no runtime behavior or security-sensitive code paths change.
Overview
The slow brew source-build e2e (
test_system_install_brew_source_slow) setsMISE_URL_REPLACEMENTSso GNU hello tarballs are fetched fromhttps://ftp.gnu.org/gnuinstead ofhttps://ftpmirror.gnu.org/gnu, which intermittently returns HTTP 502 and fails the test before mise’s source-build path runs.Inline comments document that Homebrew’s SHA-256 check still applies to the downloaded archive. No production or installer logic changes—only test stability.
Reviewed by Cursor Bugbot for commit ff36f21. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit