Repository navigation
fix(npm): route aube prompts through mise - #11441
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughAube and aube-registry are upgraded to 1.35. Embedded npm installs now route Aube confirmations through mise’s prompt UI, translate prompt variants into messages, fail closed by default, and test selected message output. ChangesEmbedded Aube prompt integration
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant InstallControl
participant AubePromptHandler
participant MisePromptUI
InstallControl->>AubePromptHandler: Request confirmation
AubePromptHandler->>MisePromptUI: Render translated message with default false
MisePromptUI-->>AubePromptHandler: Return confirmation result
AubePromptHandler-->>InstallControl: Continue or reject installation
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Greptile SummaryThis PR routes embedded aube confirmations through mise’s shared prompt UI.
Confidence Score: 5/5The PR appears safe to merge, with no concrete changed-code failure identified. The prompt handler is attached to the embedded aube install control, defaults confirmations to No, delegates terminal handling to mise’s shared prompt path, and retains the relevant warning context for each current security prompt. Important Files Changed
Reviews (1): Last reviewed commit: "fix(npm): route aube prompts through mis..." | Re-trigger Greptile |
Instruction counts
No instruction-count regression above 1%. Only instruction counts gate. Wall clock is shown for context — on identical hardware it moves 4-20% run to run. Measured by tak — instruction-counted CLI benchmarks, stored in this repository's git notes.
|
Summary
aubeandaube-registrycrates from 1.34 to 1.35Why
Embedded aube previously owned stdin directly while mise owned the progress renderer. That could leave unattended installs waiting for input, and interactive warnings could be overwritten by progress output.
Aube 1.35 includes the host prompt API from aubepkg/aube#1154. This PR wires it into the shared mise prompt path added by #11421, so mise now owns TTY detection, prompt rendering, input, and progress suspension.
This addresses the broader behavior discussed in #11375 and the overwritten prompt reported in #11417.
Validation
mise run formatmise run test:unit— 2,094 passedmise run test:e2e e2e/backend/test_npm_aubeAI-assisted — Tool: Codex; model: unavailable/unavailable; version: unavailable.
Note
Medium Risk
Changes npm install behavior for embedded aube when confirmations are required—now tied to mise’s attended-terminal rules—but scope is limited to prompt routing and a dependency bump, not resolver or trust policy logic.
Overview
Embedded npm installs now hand aube’s confirmation prompts to mise instead of letting aube read stdin directly. The embedded
aube/aube-registrycrates are bumped from 1.34 to 1.35 so the host prompt API is available.On the npm backend,
InstallControlgainsAubePromptHandler, which implements aube’sInstallPromptHandlerand callsconfirm_with_default(..., false). That reuses mise’s TTY detection and progress suspension, so CI/non-interactive runs fail closed rather than hanging, and interactive typosquat / low-download / new-package warnings are not drawn under the progress spinner.User-facing text for those three prompt kinds is built in
aube_prompt_message; other prompt variants get a generic fallback. Unit tests lock in the security wording.Reviewed by Cursor Bugbot for commit 944e28d. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
Updates