Skip to content

docs: fix dead gh CLI tool-stub example URL - #11377

Merged
jdx merged 1 commit into
jdx:mainfrom
Bartok9:docs/fix-tool-stub-gh-example-url-sera
Aug 2, 2026
Merged

jdx merged 1 commit into
jdx:mainfrom
Bartok9:docs/fix-tool-stub-gh-example-url-sera

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Tool-stub examples used cli/cli download URLs for non-existent v2.336.0 (404). Update help/docs/usage plus the platform-detection test fixture to current v2.96.0 assets (gh_2.96.0_linux_amd64.tar.gz / windows zip).

Proof: gh api repos/cli/cli/releases/tags/v2.336.0 → 404; v2.96.0 assets include those names; HEAD of linux tarball → 200.


Agent-Owner: sera · Platform: hermes · Claim: sera · Claim-TTL: 48h

Summary by CodeRabbit

  • Documentation

    • Updated mise generate tool-stub examples to reference the gh release v2.96.0, including both download URLs and resulting filenames.
    • Kept CLI help text and developer docs aligned by synchronizing the example release artifacts across the documentation set.
  • Tests

    • Updated the Windows platform-detection test URL to use the v2.96.0 release asset while preserving the existing OS/architecture assertions.

@coderabbitai

coderabbitai Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Updated GitHub CLI mise generate tool-stub examples, help text, usage metadata, and a platform-detection test from release version 2.336.0 to 2.96.0.

Changes

Tool-stub URL updates

Layer / File(s) Summary
Update tool-stub examples and validation
docs/cli/generate/tool-stub.md, docs/dev-tools/tool-stubs.md, mise.usage.kdl, src/cli/generate/tool_stub.rs, src/backend/asset_matcher.rs
Examples, help text, usage metadata, and the Windows URL fixture now reference the v2.96.0 GitHub CLI release while retaining existing formats and assertions.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: risu729, jdx

Poem

A bunny hops past URLs bright,
“Two ninety-six” now feels just right.
Docs and help all bloom anew,
Tests wear the same release hue.
One tiny leap, then off we chew!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed Docstring coverage is 100.00% which is sufficient. The required threshold is 80.00%.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: fixing a dead GitHub CLI tool-stub example URL in documentation.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 27, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

Updates the GitHub CLI tool-stub example from a nonexistent release to valid v2.96.0 assets.

  • Synchronizes the corrected Linux URL across generated docs, developer docs, CLI usage definitions, and runtime help text.
  • Updates the Windows platform-detection fixture to use the corresponding v2.96.0 asset name.

Confidence Score: 5/5

The PR appears safe to merge.

No blocking failure remains.

Important Files Changed

Filename Overview
docs/cli/generate/tool-stub.md Replaces the dead GitHub CLI example URL with the v2.96.0 Linux asset.
docs/dev-tools/tool-stubs.md Updates both the generation command and generated-stub example to the valid v2.96.0 asset.
mise.usage.kdl Keeps the command usage source synchronized with the corrected GitHub CLI example.
src/backend/asset_matcher.rs Updates the Windows platform-detection fixture while preserving the tested filename conventions and assertions.
src/cli/generate/tool_stub.rs Updates the compiled CLI help example to the corrected v2.96.0 Linux asset.

Reviews (2): Last reviewed commit: "docs: fix dead gh CLI tool-stub example ..." | Re-trigger Greptile

@Bartok9

Bartok9 commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

CI is green on the docs/tool-stub gh URL fix. Marked ready blocked from this token (GraphQL FORBIDDEN on markPullRequestReadyForReview) — happy for a maintainer to undraft when convenient, or I can re-open as non-draft if preferred.

Update generate tool-stub examples from non-existent cli/cli v2.336.0
assets to current v2.96.0 download URLs (linux amd64 tarball pattern).
@Bartok9
Bartok9 force-pushed the docs/fix-tool-stub-gh-example-url-sera branch from ec45bd2 to c11c7ad Compare July 29, 2026 11:16
@Marukome0743

Copy link
Copy Markdown
Contributor

CI is green on the docs/tool-stub gh URL fix. Marked ready blocked from this token (GraphQL FORBIDDEN on markPullRequestReadyForReview) — happy for a maintainer to undraft when convenient, or I can re-open as non-draft if preferred.

I think this PR was kept as a draft because you already had two Ready for review PRs open, which is the repository limit. Those PRs have since been merged, so you should now be able to mark this one as Ready for review through the GitHub UI.

@Bartok9
Bartok9 marked this pull request as ready for review August 2, 2026 13:36
@Bartok9

Bartok9 commented Aug 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks @Marukome0743 — that tracks. Marked ready for review now that the other PRs are merged. CI was green on the last push.

@jdx
jdx merged commit 529e27e into jdx:main Aug 2, 2026
36 checks passed
donbeave pushed a commit to donbeave/mise that referenced this pull request Aug 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants