Repository navigation
registry: allow nub postinstall - #11126
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Nub registry entry replaces the npm backend shorthand with an explicit backend object and enables builds for ChangesNub backend configuration
Estimated code review effort: 1 (Trivial) | ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR enables
Confidence Score: 5/5Safe to merge — the one-line registry change is minimal, correctly scoped, and follows established conventions. The change adds a single allow_builds entry for @nubjs/nub using the same inline options format already validated by other registry entries (amp.toml, wrangler.toml, etc.). The allowlist is narrowly scoped to the one package that needs its postinstall script, the PR description explains the motivation clearly, and the popularity metrics satisfy the registry entry requirements. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "registry: allow nub postinstall" | Re-trigger Greptile |
Summary
@nubjs/nubto run its reviewed lifecycle scriptpostinstallwarning for supported npm, aube, and pnpm installsWhy keep the npm backend
Nub publishes platform-specific GitHub release archives, and mise's GitHub backend can select and install them correctly. However, extracting those archives is not equivalent to installing the npm package.
@nubjs/nub'spostinstall.jsperforms installer-side fixups. In addition to setting executable bits for the platform binaries, it refreshes existing~/.nub/shimshardlinks so an upgrade does not leave the optionalnpm,pnpm, andyarnshims pointing at the previous Nub binary. A direct GitHub-backend extraction bypasses that refresh; affected users would have to rerunnub pm shimmanually after upgrades.Keeping the existing npm backend and setting
allow_builds = ["@nubjs/nub"]preserves upstream's install behavior without opting into arbitrary lifecycle scripts. On npm 11.16.0 and newer, mise translates this to the per-package--allow-scripts=@nubjs/nubflag. The same registry option maps to the corresponding narrow build approval for aube and pnpm.Discussion: #11119
Popularity
Validation
mise run buildmise run lint-fix@nubjs/nub@0.4.13using Node 26.5.0's bundled npm 11.17.0 with--allow-scripts=@nubjs/nub --foreground-scriptsnub --versionreturnedv0.4.13Summary by CodeRabbit
@nubjs/nubpackage.