Repository navigation
fix(task): inherit output from task templates - #11059
Conversation
Greptile SummaryThis PR fixes a gap introduced in #10885 where the per-task
Confidence Score: 5/5The change is minimal, well-contained, and follows the exact pattern already used for every other optional field in merge_template. Three-file change: a one-field struct addition with a two-line merge guard, an E2E test covering both the inheritance and local-override paths, and a doc table update. TaskOutput derives Copy, so the direct Option assignment is correct. No existing merge paths are touched. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(task): inherit output from task temp..." | Re-trigger Greptile |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughTask templates now accept an optional ChangesTask template output behavior
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary
outputin task templatesRoot cause
PR #10885 added the per-task
outputfield and exposed it through the shared task schema, but did not add the field toTaskTemplateor its merge logic. Schema-aware tooling therefore accepted template output styles that mise ignored at runtime.Unlike the task-only boolean flags,
outputis represented asOption<TaskOutput>, so template inheritance can distinguish an unset task value from an explicit local override.Validation
mise x cargo -- cargo test task_template::tests --all-featuresmise run test:e2e e2e/tasks/test_task_templatesmise run lint-fixSummary by CodeRabbit
New Features
Documentation
Bug Fixes