Repository navigation
fix(schema): allow structured task tool options - #11021
Conversation
📝 WalkthroughWalkthroughThe schemas now share a broader task-tool definition and support declarative bootstrap shell activation. Tombi fixtures add valid tool and shell activation cases plus strict negative validation for unsupported fields and values. ChangesSchema validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes the JSON Schema definitions for task tool options in both
Confidence Score: 5/5Safe to merge — the changes are purely additive schema relaxations that align validation with already-supported runtime behaviour, and both schema files remain consistent with each other. The No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "Merge branch 'main' into agent/schema-ta..." | Re-trigger Greptile |
Summary
Why
Runtime support landed in #10960, which preserves and renders nested TOML values in task tool options. The published schemas still limited unknown task tool options to strings, so editors and strict validators rejected arrays and nested tables that mise accepts.
The main schema can now reference its existing
tooldefinition directly.mise-task.jsonkeeps an equivalent local definition because it is published and validated independently; an external reference tomise.jsonwould couple standalone and offline validation to cross-file resolution.Stack
Stacked on #11004 because both changes update the shared schema fixture. Target branch remains
main.Validation
mise run render:schemamise run test:e2e config/test_schema_tombimise run lint-fixSummary by CodeRabbit
New Features
bootstrap.mise_shell_activateconfiguration to declaratively control shell activation for Bash, Zsh, Fish, and common startup/RC files.Bug Fixes / Tests
toolsentries.