Repository navigation
fix(nix): set TZDIR so timezone tests pass in the sandbox - #11019
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe Nix build environment now sets ChangesTimezone test runtime
Estimated code review effort: 1 (Trivial) | ~3 minutes Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes failing timezone-related tests in the Nix sandbox by setting the
Confidence Score: 5/5A minimal, targeted Nix config change that adds a missing zoneinfo path for tests — no production code is affected. The change is a single environment variable addition in default.nix. Referencing ${pkgs.tzdata}/share/zoneinfo as a string creates an automatic Nix store dependency, so the sandbox correctly gains access to the zoneinfo data without any explicit buildInputs entry needed. The fix is idiomatic and the comment explains the root cause clearly. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(nix): set TZDIR so timezone tests pa..." | Re-trigger Greptile |
tera-contrib'snow()resolves its timezone via a named tzdb lookup (TimeZone::get("UTC")), unlikedate()which uses the compiled-in constant, sotera::tests::test_tera_contrib_helpersandtask::task_script_parser::tests::test_task_template_tera_contrib_helpersfail withUnknown timezone: UTCin the Nix sandbox, which provides no zoneinfo.Setting
TZDIRmakes both pass rather than skipping them:1662 passed; 0 failed.Summary by CodeRabbit