Repository navigation
test(cargo): align binstall fallback coverage - #10980
Conversation
📝 WalkthroughWalkthroughThe cargo-binstall end-to-end test now sets ChangesCargo binstall verification
Estimated code review effort: 1 (Trivial) | ~2 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR fixes a test alignment issue where
Confidence Score: 5/5Single-file test change that correctly scopes an env var to the right assertion; no production code is affected. The change is a small, well-reasoned test fix. Scoping MISE_CARGO_BINSTALL_ONLY=1 inline to the eza assert (a tool with prebuilt artifacts) and removing the global export prevents the env var from leaking into the cargo-show install, which has no prebuilt artifact and would have failed under binstall-only mode. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "test(cargo): align binstall fallback cov..." | Re-trigger Greptile |
Summary
cargo.binstall_onlywitheza, which has a prebuilt artifactcargo-showcover mise's exit-94cargo installfallbackRoot cause
test_cargo_binstall_slowexportedMISE_CARGO_BINSTALL_ONLY=1forcargo-show. Sincecargo-showhas no prebuilt artifact and binstall-only now intentionally prohibits mise's compile fallback, the test asserted behavior that no longer matches the setting.Validation
mise run test:e2e e2e/backend/test_cargo_binstall_slowmise run lint-fixSummary by CodeRabbit
MISE_CARGO_BINSTALL_ONLY=1.ezaversion.