[bestagi]

Problem

Every x86_64 COPR chroot fails while aarch64 on the same targets succeeds:

Chroot	Result
fedora-rawhide-x86_64	❌ failed
fedora-44-x86_64	❌ failed
fedora-43-x86_64	❌ failed
epel-10-x86_64	❌ failed
fedora-rawhide-aarch64	✅ succeeded
fedora-44-aarch64	✅ succeeded
fedora-43-aarch64	✅ succeeded
epel-10-aarch64	✅ succeeded

Root cause: aws-lc-sys requires NASM at build time to compile x86_64-optimized assembly crypto routines. nasm was not declared as a BuildRequires, so COPR's mock chroot does not install it and the aws-lc-sys build script panics with exit status 101. aarch64 is unaffected because aws-lc-sys has no NASM dependency on that architecture.

Failing build: https://copr.fedorainfracloud.org/coprs/jdxcode/mise/build/10703774/

Fix

Fedora (%{?fedora}): add BuildRequires: nasm and BuildRequires: cmake. Both are available in standard Fedora repos on all active releases (43, 44, rawhide).

RHEL/EPEL (%{?rhel}): export AWS_LC_SYS_NO_ASM=1 before cargo build. On EL9/EL10, nasm lives in CRB (CodeReady Builder) which is not enabled in COPR chroots by default. AWS_LC_SYS_NO_ASM=1 disables the ASM path, falling back to portable C — performance impact is negligible for mise's usage patterns (tool downloads, not throughput-sensitive crypto).

BuildRequires:  cmake
%if 0%{?fedora}
BuildRequires:  nasm
%endif

%if 0%{?rhel}
export AWS_LC_SYS_NO_ASM=1
%endif
cargo build --profile __BUILD_PROFILE__ --frozen --bin mise

Testing

This fix covers all 4 failing x86_64 chroots with a single conditional approach that requires no extra repo configuration in COPR.

Summary by CodeRabbit

• Bug Fixes
  • Improved RPM build reliability across Fedora and RHEL by adjusting the generated spec’s build requirements.
  • Added an unconditional CMake build dependency to ensure consistent builds.
  • Enabled NASM support only for Fedora x86_64 builds, while RHEL x86_64 builds now use prebuilt NASM objects instead of requiring NASM in the COPR chroot.

[coderabbitai]

📝 Walkthrough

Walkthrough

The COPR RPM spec now includes CMake, conditionally requires NASM on Fedora x86_64, and enables prebuilt NASM objects for RHEL x86_64 builds.

Changes

COPR RPM build configuration

Layer / File(s)	Summary
Distro-specific RPM build setup packaging/copr/build-copr.sh	The generated spec adds CMake, limits NASM to Fedora x86_64, and exports AWS_LC_SYS_PREBUILT_NASM=1 for RHEL x86_64 builds.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

I’m a bunny with a build in flight,
CMake hops in, NASM stays light.
Fedora gets its tools in line,
RHEL prebuilt parts take flight.
COPR builds now spring just right!

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately describes the COPR build fix for x86_64, including Fedora NASM/cmake dependencies and the RHEL/EPEL PREBUILT_NASM change.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[greptile-apps]

Greptile Summary

This PR fixes x86_64 COPR build failures for mise by adding missing build dependencies (cmake, nasm) to the RPM spec and working around the unavailability of NASM in RHEL/EPEL COPR chroots.

• Fedora fix (correct): adds BuildRequires: cmake unconditionally and BuildRequires: nasm gated on %{?fedora} && x86_64. This directly addresses the root cause and the architecture guard is correctly scoped.
• RHEL/EPEL fix (broken): exports AWS_LC_SYS_PREBUILT_NASM=1 on RHEL x86_64, but per the official aws-lc-rs docs and build script source, this variable is a Windows-only feature \u2014 the use_prebuilt_nasm() function gates on target_os() == \"windows\" and is a no-op on Linux. RHEL x86_64 builds will still fail.

Confidence Score: 4/5

The Fedora half of the fix is correct and safe to merge; the RHEL/EPEL half relies on a Windows-only environment variable that has no effect on Linux and will leave RHEL x86_64 builds broken.

The AWS_LC_SYS_PREBUILT_NASM=1 export for RHEL is documented as a Windows-only control in aws-lc-sys — it does nothing on Linux. The RHEL x86_64 chroots will still fail to find NASM during the aws-lc-sys build step.

packaging/copr/build-copr.sh — specifically the RHEL %build section that sets AWS_LC_SYS_PREBUILT_NASM

Important Files Changed

Filename	Overview
packaging/copr/build-copr.sh	Fixes Fedora x86_64 COPR builds correctly (nasm + cmake BuildRequires, arch-guarded), but the RHEL/EPEL fix uses AWS_LC_SYS_PREBUILT_NASM=1 which is a Windows-only env var in aws-lc-sys and has no effect on Linux builds — RHEL x86_64 will still fail

_{Reviews (3): Last reviewed commit: "fix(copr): replace AWS_LC_SYS_NO_ASM wit..." | Re-trigger Greptile}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@packaging/copr/build-copr.sh`:
- Around line 227-233: The RHEL/EPEL workaround in the RPM build must not export
AWS_LC_SYS_NO_ASM for the default release profile, because aws-lc-sys rejects it
there. Update the surrounding build-profile logic near BUILD_PROFILE to use a
supported no-ASM configuration for release builds, or enable the required
NASM/CRB dependency instead, while preserving successful builds on RHEL/EPEL.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 2ac0d952-c62f-4ea4-8b03-48a963bceca4

📥 Commits

Reviewing files that changed from the base of the PR and between 588d2e7 and 2265302.

📒 Files selected for processing (1)

• packaging/copr/build-copr.sh

[bestagi]

wait prebuilt_nasm only for windows, will fix it later.
or maybe turn on CRB in COPR project setting ? @jdx

[bestagi]

oh wait, copr publish process are canceled and its still broke, i will check it again tomorrow @jdx