Skip to content

revert: prefer aqua for codex - #10922

Merged
jdx merged 2 commits into
jdx:mainfrom
risu729:registry/prefer-aqua-for-codex
Jul 12, 2026
Merged

jdx merged 2 commits into
jdx:mainfrom
risu729:registry/prefer-aqua-for-codex

Conversation

@risu729

@risu729 risu729 commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Why

The missing codex-code-mode-host issue was already fixed upstream in aquaproj/aqua-registry#56498 (merged 2026-07-06), which switched openai/codex from the loose codex-* asset to the official codex-package-* archives that include bin/codex-code-mode-host (and the rest of the package layout).

That aqua-registry change was already baked into released mise binaries starting with v2026.7.1 (2026-07-07), i.e. before #10893 landed (2026-07-09). I'm not sure why #10893 was still needed after that — happy to be corrected if there's another failure mode I'm missing.

Validation

  • Confirmed macOS codex-package-*-apple-darwin.tar.gz for rust-v0.144.0 contains bin/codex-code-mode-host (archive listing / file presence only — did not run Codex end-to-end on macOS)
  • Confirmed mise install aqua:openai/codex@0.144.0 on Linux with 2026.7.5 extracts the package archive and leaves bin/codex-code-mode-host in place; bin-paths points at .../bin

Made with Cursor

Summary by CodeRabbit

  • Bug Fixes
    • Updated Codex backend selection to prioritize the Aqua package over the npm package.
  • Tests
    • Removed the unit test that asserted the previous Codex backend preference.

@coderabbitai

coderabbitai Bot commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 8c1fcf07-71e3-4cd9-a03f-4140fd9965ac

📥 Commits

Reviewing files that changed from the base of the PR and between bb56a0e and 195c33f.

📒 Files selected for processing (1)
  • src/registry.rs
✅ Files skipped from review due to trivial changes (1)
  • src/registry.rs

📝 Walkthrough

Walkthrough

The Codex registry now lists aqua:openai/codex before npm:@openai/codex``. The unit test requiring npm to be first was removed.

Changes

Codex registry update

Layer / File(s) Summary
Update Codex backend priority
registry/codex.toml, src/registry.rs
The Aqua backend is listed first, and the test asserting npm backend priority is removed.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

  • jdx/mise#10893: Changes the same Codex backend ordering and adds the npm-priority test removed here.

Poem

A bunny hops through Codex’s queue,
Aqua leads with ears held high.
The old npm test bids adieu,
While tidy registry entries fly.
Thump, thump—priority’s changed!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the change: it reverts codex to prefer the aqua backend.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 10, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR reverts #10893 by restoring aqua:openai/codex as the preferred backend for the codex registry entry, with npm:@openai/codex as fallback. The upstream aqua-registry fix (aquaproj/aqua-registry#56498) that addressed the missing codex-code-mode-host binary was already included in mise v2026.7.1, making the npm-first workaround unnecessary.

  • registry/codex.toml: backend list reordered back to [\"aqua:openai/codex\", \"npm:@openai/codex\"]
  • src/registry.rs: removes the test that asserted npm was the first backend, since it only validated the now-reverted ordering

Confidence Score: 5/5

Safe to merge — a minimal two-line revert restoring the original aqua-first backend ordering now that the upstream registry fix is in production.

The change is a targeted revert of a single ordering decision in a TOML file and its accompanying test. The upstream fix is documented and the author confirmed the corrected archive layout on both macOS and Linux.

No files require special attention.

Important Files Changed

Filename Overview
registry/codex.toml Reverts backend ordering to prefer aqua:openai/codex over npm:@openai/codex, matching the original pre-#10893 state.
src/registry.rs Removes the test_codex_prefers_official_npm_package test that was introduced in #10893 alongside the npm-first ordering.

Reviews (2): Last reviewed commit: "chore: merge origin/main into registry/p..." | Re-trigger Greptile

Comment thread src/registry.rs Resolved
@risu729
risu729 marked this pull request as ready for review July 10, 2026 16:18
@jdx
jdx enabled auto-merge (squash) July 12, 2026 00:21
@jdx
jdx merged commit b574e15 into jdx:main Jul 12, 2026
34 checks passed
@risu729
risu729 deleted the registry/prefer-aqua-for-codex branch July 12, 2026 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants