Skip to content

fix(task): correct env for task.show_full_cmd setting - #10714

Merged
jdx merged 1 commit into
jdx:mainfrom
muzimuzhi:fix/env-for-task.show_full_cmd
Jul 2, 2026
Merged

jdx merged 1 commit into
jdx:mainfrom
muzimuzhi:fix/env-for-task.show_full_cmd

Conversation

@muzimuzhi

Copy link
Copy Markdown
Contributor

Fix a leftover of setting renaming happened during #7344.

@coderabbitai

coderabbitai Bot commented Jul 2, 2026 •

Copy link
Copy Markdown
Contributor

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 5e90f8a2-162d-46c0-a8f8-cdb16410520c

📥 Commits

Reviewing files that changed from the base of the PR and between 5749676 and 019f503.

📒 Files selected for processing (2)
  • e2e/tasks/test_task_show_full_cmd
  • settings.toml
👮 Files not reviewed due to content moderation or server errors (2)
  • e2e/tasks/test_task_show_full_cmd
  • settings.toml

📝 Walkthrough

[!WARNING]

Walkthrough skipped

File diffs could not be summarized.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR fixes a stale environment variable name left over from a setting rename in #7344. The task.show_full_cmd setting's env field in settings.toml was still pointing to the old name MISE_TASK_SHOW_CMD_NO_TRUNC instead of MISE_TASK_SHOW_FULL_CMD, making it impossible to configure the setting via the environment.

  • settings.toml: Corrects env = "MISE_TASK_SHOW_CMD_NO_TRUNC" to env = "MISE_TASK_SHOW_FULL_CMD" for the [task.show_full_cmd] entry.
  • e2e/tasks/test_task_show_full_cmd: Updates both the descriptive comment and the assert_contains invocation to reference the corrected env var name.

Confidence Score: 5/5

Safe to merge — the change is a targeted two-line rename with no logic changes and no remaining uses of the old name in the repo.

The old env var MISE_TASK_SHOW_CMD_NO_TRUNC no longer appears anywhere in the codebase after this change, confirming a clean rename. The e2e test is updated consistently, and the setting definition now matches the intended name established when the setting was renamed.

No files require special attention.

Important Files Changed

Filename Overview
settings.toml Corrects the env var for task.show_full_cmd from MISE_TASK_SHOW_CMD_NO_TRUNC to MISE_TASK_SHOW_FULL_CMD
e2e/tasks/test_task_show_full_cmd Updates test comment and assert_contains call to use the now-correct env var MISE_TASK_SHOW_FULL_CMD

Reviews (1): Last reviewed commit: "fix(task): correct env for `task.show_fu..." | Re-trigger Greptile

@jdx
jdx merged commit d9f6535 into jdx:main Jul 2, 2026
31 of 34 checks passed
@muzimuzhi
muzimuzhi deleted the fix/env-for-task.show_full_cmd branch September 18, 2026 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants