Repository navigation
fix(copr): drop retired Fedora 42 chroots - #10698
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe change refactors ChangesCOPR Chroot Defaults Refactor
Estimated code review effort: 1 (Trivial) | ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryRemoves the retired Fedora 42 chroots (
Confidence Score: 5/5Straightforward maintenance change — removes two retired chroots and avoids a copy-paste drift bug in help output. The only file touched is the COPR build script. The two fedora-42 chroot entries are simply removed, and the refactor to DEFAULT_CHROOTS is correct: the variable is set before it's used in both the CHROOTS default assignment and the usage() echo, so the help text will always reflect the actual runtime default without any further manual synchronization. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(copr): drop retired Fedora 42 chroot..." | Re-trigger Greptile |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.14 x -- echo |
25.7 ± 2.5 | 20.9 | 37.4 | 1.00 |
mise x -- echo |
25.7 ± 2.5 | 20.9 | 49.9 | 1.00 ± 0.14 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.14 env |
24.6 ± 1.9 | 20.6 | 34.6 | 1.00 |
mise env |
25.1 ± 2.2 | 20.4 | 32.8 | 1.02 ± 0.12 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.14 hook-env |
24.1 ± 1.4 | 20.9 | 29.5 | 1.00 |
mise hook-env |
25.1 ± 1.5 | 21.5 | 30.1 | 1.04 ± 0.09 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.14 ls |
20.1 ± 1.3 | 17.0 | 24.6 | 1.00 |
mise ls |
20.6 ± 1.4 | 17.4 | 25.9 | 1.02 ± 0.09 |
xtasks/test/perf
| Command | mise-2026.6.14 | mise | Variance |
|---|---|---|---|
| install (cached) | 155ms | 157ms | -1% |
| ls (cached) | 70ms | 71ms | -1% |
| bin-paths (cached) | 77ms | 77ms | +0% |
| task-ls (cached) | 150ms | 150ms | +0% |
Summary
DEFAULT_CHROOTSin the help output so usage text stays in sync with the real default.Refs #10654.
Validation
bash -n packaging/copr/build-copr.shif rg -n "fedora-42" packaging/copr/build-copr.sh; then exit 1; else echo "No fedora-42 chroots remain"; fibash packaging/copr/build-copr.sh --help | rg "COPR chroots"https://copr.fedorainfracloud.org/api_3/mock-chroots/list.This PR description was generated by an AI coding assistant.
Note
Low Risk
Packaging-only change to COPR chroot defaults; no runtime or application code affected.
Overview
Updates the COPR release script so default builds no longer target retired Fedora 42 (
fedora-42-aarch64/fedora-42-x86_64).The default chroot list is now defined once in
DEFAULT_CHROOTS, withCHROOTSdefaulting to that value and--helpprinting the same list, so the documented defaults stay aligned with what the script actually submits.Reviewed by Cursor Bugbot for commit 6bb0649. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
--chrootshelp text so it now shows the current default values automatically.