Skip to content

fix(copr): drop retired Fedora 42 chroots - #10698

Merged
jdx merged 1 commit into
mainfrom
codex/drop-fedora-42-copr
Jul 1, 2026
Merged

jdx merged 1 commit into
mainfrom
codex/drop-fedora-42-copr

Conversation

@jdx

@jdx jdx commented Jul 1, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • Drop retired Fedora 42 COPR chroots from the default build list.
  • Reuse DEFAULT_CHROOTS in the help output so usage text stays in sync with the real default.

Refs #10654.

Validation

  • bash -n packaging/copr/build-copr.sh
  • if rg -n "fedora-42" packaging/copr/build-copr.sh; then exit 1; else echo "No fedora-42 chroots remain"; fi
  • bash packaging/copr/build-copr.sh --help | rg "COPR chroots"
  • Verified every remaining default chroot against https://copr.fedorainfracloud.org/api_3/mock-chroots/list.

This PR description was generated by an AI coding assistant.


Note

Low Risk
Packaging-only change to COPR chroot defaults; no runtime or application code affected.

Overview
Updates the COPR release script so default builds no longer target retired Fedora 42 (fedora-42-aarch64 / fedora-42-x86_64).

The default chroot list is now defined once in DEFAULT_CHROOTS, with CHROOTS defaulting to that value and --help printing the same list, so the documented defaults stay aligned with what the script actually submits.

Reviewed by Cursor Bugbot for commit 6bb0649. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Bug Fixes
    • Updated the default COPR chroot selection to use the latest supported set.
    • Adjusted the --chroots help text so it now shows the current default values automatically.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a9d2c948-d435-4de2-800f-40e55e45eae1

📥 Commits

Reviewing files that changed from the base of the PR and between c3534bc and 6bb0649.

📒 Files selected for processing (1)
  • packaging/copr/build-copr.sh

📝 Walkthrough

Walkthrough

The change refactors packaging/copr/build-copr.sh to introduce a DEFAULT_CHROOTS variable, used as the fallback default for CHROOTS and referenced in the usage() help text, replacing the previous hardcoded chroot list.

Changes

COPR Chroot Defaults Refactor

Layer / File(s) Summary
Default chroot variable and usage sync
packaging/copr/build-copr.sh
Introduces DEFAULT_CHROOTS as the fallback for CHROOTS, replacing the hardcoded default list, and updates the usage() text to reference the variable.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Poem

A rabbit hopped through scripts today,
Trimming chroots that led astray,
One tidy list, now stored with care,
DEFAULT_CHROOTS everywhere! 🐇
Hop hop, the build is clean and bright.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly matches the main change: removing retired Fedora 42 chroots from COPR defaults.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@greptile-apps

greptile-apps Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Removes the retired Fedora 42 chroots (fedora-42-aarch64, fedora-42-x86_64) from the COPR build defaults, and extracts the default chroot list into a DEFAULT_CHROOTS variable so the --help output stays automatically in sync with the real default.

  • DEFAULT_CHROOTS is set at the top of the script and referenced by both CHROOTS="${CHROOTS:-$DEFAULT_CHROOTS}" and the usage() help line, eliminating the previous duplication that caused the help text and runtime default to diverge.
  • The remaining chroots (fedora-rawhide, fedora-44, fedora-43, epel-10, centos-stream+epel-next-9) are all still active targets.

Confidence Score: 5/5

Straightforward maintenance change — removes two retired chroots and avoids a copy-paste drift bug in help output.

The only file touched is the COPR build script. The two fedora-42 chroot entries are simply removed, and the refactor to DEFAULT_CHROOTS is correct: the variable is set before it's used in both the CHROOTS default assignment and the usage() echo, so the help text will always reflect the actual runtime default without any further manual synchronization.

No files require special attention.

Important Files Changed

Filename Overview
packaging/copr/build-copr.sh Drops retired fedora-42 chroots from DEFAULT_CHROOTS and refactors help text to reference the variable instead of a hardcoded duplicate list

Reviews (1): Last reviewed commit: "fix(copr): drop retired Fedora 42 chroot..." | Re-trigger Greptile

@jdx
jdx enabled auto-merge (squash) July 1, 2026 22:43
@github-actions

github-actions Bot commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.14 x -- echo 25.7 ± 2.5 20.9 37.4 1.00
mise x -- echo 25.7 ± 2.5 20.9 49.9 1.00 ± 0.14

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.14 env 24.6 ± 1.9 20.6 34.6 1.00
mise env 25.1 ± 2.2 20.4 32.8 1.02 ± 0.12

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.14 hook-env 24.1 ± 1.4 20.9 29.5 1.00
mise hook-env 25.1 ± 1.5 21.5 30.1 1.04 ± 0.09

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.14 ls 20.1 ± 1.3 17.0 24.6 1.00
mise ls 20.6 ± 1.4 17.4 25.9 1.02 ± 0.09

xtasks/test/perf

Command mise-2026.6.14 mise Variance
install (cached) 155ms 157ms -1%
ls (cached) 70ms 71ms -1%
bin-paths (cached) 77ms 77ms +0%
task-ls (cached) 150ms 150ms +0%

@jdx
jdx merged commit 259af02 into main Jul 1, 2026
33 of 34 checks passed
@jdx
jdx deleted the codex/drop-fedora-42-copr branch July 1, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant