Repository navigation
docs: add mise song page - #10614
docs: add mise song page#10614
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (2)
📝 WalkthroughWalkthroughA new documentation page for “mise-en-place: The Song” was added, and the VitePress sidebar now links to it from the About section. ChangesMise-en-place song docs
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Greptile SummaryThis PR adds a fun "mise-en-place: The Song" documentation page featuring an embedded HTML5 audio player and full lyrics, wired into the About sidebar.
Confidence Score: 4/5Safe to merge; the only concerns are the large binary in git history and a minor audio preload attribute choice. The docs change is straightforward and correct — the VitePress asset path, sidebar link, and HTML5 audio element all look right. The main thing worth a second look is the ~5 MB MP3 committed directly to git: it will permanently increase clone size for every future contributor. Hosting it externally and referencing an absolute URL would avoid that. docs/public/mise-en-place.mp3 — consider whether a ~5 MB binary belongs in git history or should live on an external CDN. Important Files Changed
|
| @@ -0,0 +1,49 @@ | |||
| # mise-en-place: The Song | |||
|
|
|||
| <audio controls preload="metadata" src="/mise-en-place.mp3"> | |||
There was a problem hiding this comment.
preload="metadata" causes the browser to immediately fetch the beginning of the MP3 to read duration/bitrate info, even if the visitor never plays it. Since this is an optional fun page, preload="none" defers all network traffic until the user actually clicks play — better for visitors on metered connections.
| <audio controls preload="metadata" src="/mise-en-place.mp3"> | |
| <audio controls preload="none" src="/mise-en-place.mp3"> |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.13 x -- echo |
18.6 ± 0.8 | 17.0 | 21.7 | 1.00 |
mise x -- echo |
19.4 ± 1.4 | 17.7 | 40.1 | 1.05 ± 0.09 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.13 env |
18.6 ± 0.8 | 17.1 | 22.7 | 1.00 |
mise env |
19.3 ± 0.8 | 17.8 | 22.3 | 1.04 ± 0.06 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.13 hook-env |
19.0 ± 0.7 | 17.6 | 22.3 | 1.00 |
mise hook-env |
19.9 ± 0.8 | 18.4 | 23.7 | 1.05 ± 0.06 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.13 ls |
16.0 ± 0.7 | 14.4 | 19.3 | 1.00 |
mise ls |
17.0 ± 1.1 | 15.1 | 21.7 | 1.07 ± 0.08 |
xtasks/test/perf
| Command | mise-2026.6.13 | mise | Variance |
|---|---|---|---|
| install (cached) | 139ms | 142ms | -2% |
| ls (cached) | 64ms | 65ms | -1% |
| bin-paths (cached) | 73ms | 73ms | +0% |
| task-ls (cached) | 145ms | 148ms | -2% |
Summary
Test
This PR was generated by an AI coding assistant.
Note
Low Risk
Documentation and navigation only; no runtime, auth, or product logic changes.
Overview
Adds a new About docs page, mise-en-place: The Song, with an embedded HTML5 audio player pointing at
/mise-en-place.mp3and the full lyrics in a text block.The VitePress sidebar in
docs/.vitepress/config.tsnow links to/mise-en-placeright after About mise.Reviewed by Cursor Bugbot for commit 322ae38. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit