Skip to content

docs: add mise song page - #10614

Merged
jdx merged 1 commit into
mainfrom
codex/add-mise-song-page
Jun 25, 2026
Merged

jdx merged 1 commit into
mainfrom
codex/add-mise-song-page

Conversation

@jdx

@jdx jdx commented Jun 25, 2026 •

Copy link
Copy Markdown
Owner

Summary

  • add a new docs page for the mise-en-place song with an embedded MP3 player
  • include the full lyrics on the page
  • add the page to the About sidebar

Test

  • mise run docs:build

This PR was generated by an AI coding assistant.


Note

Low Risk
Documentation and navigation only; no runtime, auth, or product logic changes.

Overview
Adds a new About docs page, mise-en-place: The Song, with an embedded HTML5 audio player pointing at /mise-en-place.mp3 and the full lyrics in a text block.

The VitePress sidebar in docs/.vitepress/config.ts now links to /mise-en-place right after About mise.

Reviewed by Cursor Bugbot for commit 322ae38. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • New Features
    • Added a new “mise-en-place: The Song” page to the documentation site.
    • Included an embedded audio player and lyrics content on the new page.
    • Added a new sidebar link in the About section for easier access to the page.

@coderabbitai

coderabbitai Bot commented Jun 25, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Central YAML (base), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: a0d5f342-c399-480d-9a8a-5e0ba4a59a85

📥 Commits

Reviewing files that changed from the base of the PR and between 4ef22b1 and 322ae38.

⛔ Files ignored due to path filters (1)
  • docs/public/mise-en-place.mp3 is excluded by !**/*.mp3
📒 Files selected for processing (2)
  • docs/.vitepress/config.ts
  • docs/mise-en-place.md

📝 Walkthrough

Walkthrough

A new documentation page for “mise-en-place: The Song” was added, and the VitePress sidebar now links to it from the About section.

Changes

Mise-en-place song docs

Layer / File(s) Summary
Song page and sidebar entry
docs/mise-en-place.md, docs/.vitepress/config.ts
Adds the new /mise-en-place documentation page with embedded audio and lyrics, and adds a sidebar link to it under About.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Poem

🐰 I hopped to the About tree,
And found a song page waiting for me.
With lyrics bright and music near,
A bunny hums and thumps with cheer!


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@jdx
jdx merged commit 512bf98 into main Jun 25, 2026
17 of 19 checks passed
@jdx
jdx deleted the codex/add-mise-song-page branch June 25, 2026 00:53
@greptile-apps

greptile-apps Bot commented Jun 25, 2026 •

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR adds a fun "mise-en-place: The Song" documentation page featuring an embedded HTML5 audio player and full lyrics, wired into the About sidebar.

  • docs/mise-en-place.md — new page with a standard <audio> element pointing at the public asset and the complete song lyrics in a code block.
  • docs/.vitepress/config.ts — sidebar entry added between "About mise" and "Glossary".
  • docs/public/mise-en-place.mp3 — ~5 MB binary MP3 committed directly to the repository.

Confidence Score: 4/5

Safe to merge; the only concerns are the large binary in git history and a minor audio preload attribute choice.

The docs change is straightforward and correct — the VitePress asset path, sidebar link, and HTML5 audio element all look right. The main thing worth a second look is the ~5 MB MP3 committed directly to git: it will permanently increase clone size for every future contributor. Hosting it externally and referencing an absolute URL would avoid that.

docs/public/mise-en-place.mp3 — consider whether a ~5 MB binary belongs in git history or should live on an external CDN.

Important Files Changed

Filename Overview
docs/.vitepress/config.ts Adds a sidebar entry for the new song page under the "About" section, correctly linking to /mise-en-place.
docs/mise-en-place.md New docs page with an HTML5 audio player and full song lyrics; uses correct VitePress public-asset path.
docs/public/mise-en-place.mp3 ~5 MB binary MP3 committed directly to git history; will permanently inflate repository size for all future clones.

Comments Outside Diff (1)

  1. docs/public/mise-en-place.mp3, line 1 (link)

    P2 ~5 MB binary committed to git history

    The MP3 (~4.95 MB) will be permanently embedded in the repository's git history and downloaded by every fresh clone. Consider hosting it on an external CDN (e.g. GitHub Releases assets, Cloudflare R2, or a public storage bucket) and referencing it via an absolute URL in the src attribute — this avoids permanently bloating the repo for all future contributors.

    Fix in Claude Code

Fix All in Claude Code

Reviews (1): Last reviewed commit: "docs: add mise song page" | Re-trigger Greptile

Comment thread docs/mise-en-place.md
@@ -0,0 +1,49 @@
# mise-en-place: The Song

<audio controls preload="metadata" src="/mise-en-place.mp3">

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 preload="metadata" causes the browser to immediately fetch the beginning of the MP3 to read duration/bitrate info, even if the visitor never plays it. Since this is an optional fun page, preload="none" defers all network traffic until the user actually clicks play — better for visitors on metered connections.

Suggested change
<audio controls preload="metadata" src="/mise-en-place.mp3">
<audio controls preload="none" src="/mise-en-place.mp3">

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Fix in Claude Code

@github-actions

Copy link
Copy Markdown
Contributor

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.13 x -- echo 18.6 ± 0.8 17.0 21.7 1.00
mise x -- echo 19.4 ± 1.4 17.7 40.1 1.05 ± 0.09

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.13 env 18.6 ± 0.8 17.1 22.7 1.00
mise env 19.3 ± 0.8 17.8 22.3 1.04 ± 0.06

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.13 hook-env 19.0 ± 0.7 17.6 22.3 1.00
mise hook-env 19.9 ± 0.8 18.4 23.7 1.05 ± 0.06

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.13 ls 16.0 ± 0.7 14.4 19.3 1.00
mise ls 17.0 ± 1.1 15.1 21.7 1.07 ± 0.08

xtasks/test/perf

Command mise-2026.6.13 mise Variance
install (cached) 139ms 142ms -2%
ls (cached) 64ms 65ms -1%
bin-paths (cached) 73ms 73ms +0%
task-ls (cached) 145ms 148ms -2%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant