registry: add SQLcl (aqua:oracle.com/sqlcl)#10417
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
📝 WalkthroughWalkthroughA new registry entry ChangesSQLcl Registry Entry
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryAdds a single-file registry entry for Oracle SQLcl (
Confidence Score: 5/5The change is a single minimal TOML registry entry; it cannot break existing functionality and is technically well-formed. The file is a three-line registry stub with correct syntax and a format consistent with all other Java-backed registry entries. There are no logic paths to break and no code changes beyond the registry file itself. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "Pass lint" | Re-trigger Greptile |
| description = "Oracle SQLcl command-line interface for Oracle Database" | ||
| backends = ["aqua:oracle.com/sqlcl"] | ||
| test = { cmd = "sql -V", expected = "SQLcl", tools = ["java"] } |
There was a problem hiding this comment.
Missing GitHub star count in PR description
The repository's contribution guidelines require that new registry tool PRs include a GitHub star popularity count. The PR description explicitly states there is no star count and substitutes VSCode extension install metrics instead. The backing GitHub repo (jasonlyle88/sqlcl) was created specifically for aqua/mise packaging, so it will have near-zero stars — but the rule exists to gate tool popularity, and the proxy metric provided (extension installs for a different product) doesn't satisfy the stated requirement.
Rule Used: What: new registry tools must include the github s... (source)
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
This PR currently has failing checks. If this continues for 7 days, it will be closed automatically. This is warning day 1 of 7. Please update the PR when you have a chance. Feel free to reopen or create a new PR if it is closed and you'd like to continue working on it. This comment was generated by an automated workflow. |
| @@ -0,0 +1,3 @@ | |||
| backends = ["aqua:oracle.com/sqlcl"] | |||
| description = "Oracle SQLcl command-line interface for Oracle Database" | |||
| test = { cmd = "sql -V", expected = "SQLcl", tools = ["java"] } | |||
There was a problem hiding this comment.
Something you can only get away with when you're Oracle
Adds a registry entry for Oracle's SQLcl, the CLI tool for Oracle databases. This is backed by the
aqua:oracle.com/sqlclpackage.https://www.oracle.com/database/sqldeveloper/technologies/sqlcl/
This is the official Oracle CLI tool for interfacing with the database. In addition to interfacing with the database, it has an integrated MCP server and embeds liquibase (which is already an available mise tool), among many other features for Oracle databases.
SQLcl is released on a quarterly schedule (at minimum), with the current release always available here and all previous supported releases always available here. The most recent releases have been on:
This is released directly by Oracle, so I don't have a star count or any direct metrics.
In lieu of this, I offer the popularity of the GUI counterpart: https://marketplace.visualstudio.com/items?itemName=Oracle.sql-developer. This had 887,521 installs at the time of writing this PR. Obviously not a direct correlation, but I think a pretty strong indicator of the popularity as it it truly is just a GUI around the tool (a connection created in one will show up in the other even).
One note in case you go digging: the github repo backing the aqua package is just a release metadata repository to allow for version discovery and checksum verification. So the fact that is is new (I recently created it for the purpose of aqua/mise!) and doesn't have stars is not surprising... its not really supposed to be a visible repo.
Summary by CodeRabbit