refactor(file): derive extraction format extensions from display#10412
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThis PR refactors ChangesExtractionFormat Extension Refactor
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryThis PR refactors
Confidence Score: 5/5Safe to merge — pure refactor with no behavior changes; all callers of The change replaces a hand-maintained 19-arm match with a one-liner backed by strum's No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "refactor(file): derive extraction format..." | Re-trigger Greptile |
49910ad to
e12af9d
Compare
Summary
ExtractionFormat::extension()from the enum display string for non-raw formatsZipdisplay tozipwhile preservingvsixparsingextension()returns an owned stringConflict check
git merge-tree; no conflicts, so this PR is independent rather than stacked.Tests
cargo fmtcargo test test_extraction_format_extension_uses_canonical_displaycargo test test_extraction_format_from_file_namecargo checkSummary by CodeRabbit
Bug Fixes
Tests