fix(task): validate monorepo-relative task refs#10342
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughValidator now resolves task pattern references relative to the current task using ChangesMonorepo Task Validation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryThis PR fixes
Confidence Score: 5/5The change is validation-only and mirrors the existing runtime resolution path; no task execution logic is modified. Both changed files are well-contained: the logic change in validate.rs delegates to already-tested helpers rather than introducing new resolution logic, and the e2e test covers all four reference forms end-to-end with proper fixture cleanup. No files require special attention. Important Files Changed
Reviews (2): Last reviewed commit: "fix(task): validate monorepo task aliase..." | Re-trigger Greptile |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 64f3cad. Configure here.
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.3 x -- echo |
18.4 ± 0.8 | 16.9 | 22.4 | 1.00 |
mise x -- echo |
19.1 ± 1.7 | 17.6 | 50.6 | 1.04 ± 0.10 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.3 env |
18.3 ± 0.8 | 16.8 | 23.0 | 1.00 |
mise env |
20.0 ± 1.4 | 17.4 | 24.7 | 1.09 ± 0.09 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.3 hook-env |
20.8 ± 1.4 | 18.0 | 29.1 | 1.00 |
mise hook-env |
21.0 ± 1.4 | 18.7 | 27.5 | 1.01 ± 0.09 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.6.3 ls |
18.9 ± 2.5 | 15.1 | 27.6 | 1.00 |
mise ls |
23.3 ± 2.7 | 17.6 | 31.2 | 1.24 ± 0.22 |
ls measured 24% slower, but the relative uncertainty overlaps the 10% threshold. |
xtasks/test/perf
| Command | mise-2026.6.3 | mise | Variance |
|---|---|---|---|
| install (cached) | 148ms | 147ms | +0% |
| ls (cached) | 65ms | 64ms | +1% |
| bin-paths (cached) | 71ms | 75ms | -5% |
| task-ls (cached) | 141ms | 139ms | +1% |

Summary
tasks validatechecks for missing dependenciesrunentries:task, and//pkg:taskdependencies inside a monorepo config_rootDiscussion: #10329
Tests
cargo fmt --checkmise run test:e2e e2e/tasks/test_task_validateThis PR was generated by an AI coding assistant.
Note
Low Risk
Scoped to validation-only lookup logic with e2e coverage; no changes to task execution paths beyond matching existing runtime behavior.
Overview
mise tasks validatenow resolves task references the same way runtime does, using the parent task for monorepo-relative patterns instead of treating dependency andruntargets as plain global names.task_existscallsresolve_task_patternandbuild_task_ref_map/get_matching, so checks fordepends,depends_post,wait_for, andruntask entries accept bare names,:task,//pkg:task, and aliases inside monorepo config roots without false missing-dependency errors.E2e coverage adds a small monorepo fixture and asserts
tasks validatepasses frompkgwhilemise runstill executes those dependencies correctly.Reviewed by Cursor Bugbot for commit 7c3f37a. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Tests
Bug Fixes