Skip to content

test(completions): update usage 3.5 expectations#10340

Merged
jdx merged 1 commit into
mainfrom
chore/update-usage-cli-3.5
Jun 12, 2026
Merged

test(completions): update usage 3.5 expectations#10340
jdx merged 1 commit into
mainfrom
chore/update-usage-cli-3.5

Conversation

@jdx

@jdx jdx commented Jun 12, 2026

Copy link
Copy Markdown
Owner

Summary

  • Update zsh completion e2e expectations for usage 3.5's two-tab description separator
  • Keep the PR scoped to the test fallout from the latest usage CLI behavior

Test

  • mise run test:e2e e2e/tasks/test_task_completion e2e/tasks/test_task_completion_global_cd

Note

Low Risk
Test-only assertion updates with no production code or behavior changes in mise itself.

Overview
Updates zsh task-completion e2e tests to match usage 3.5 output from usage complete-word --shell zsh: the value/description pair now uses a two-tab separator instead of one.

Expected strings in test_task_completion and test_task_completion_global_cd are adjusted accordingly (e.g. alpha\talphaalpha\t\talpha). No mise runtime or completion logic changes—only test expectations for the newer usage CLI.

Reviewed by Cursor Bugbot for commit 86133aa. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Tests
    • Updated e2e test assertions for task completion output formatting to ensure accurate validation of completion behavior across various scenarios and flag combinations.

@coderabbitai

coderabbitai Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

📝 Walkthrough

Walkthrough

Two e2e tests update their assertion expectations to match the current completion output formatting. The first test adjusts whitespace and tab spacing in the mise.toml and mise.usage.kdl output lines. The second test updates expected profile completion strings across multiple scenarios, including baseline completion, with -C . flag variants, and with orphan flags like -r and -S.

Changes

Task Completion Test Assertions

Layer / File(s) Summary
Task completion assertion updates
e2e/tasks/test_task_completion, e2e/tasks/test_task_completion_global_cd
Expected output strings updated to match current completion formatting: tab spacing and line wrapping in basic completion test; profile argument choices formatted consistently across baseline, -C ., and flag scenarios in the global flag variant test.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • jdx/mise#10181: Main PR updates e2e assertions for task completion output formatting including tab-separated choice formatting, which matches the completion-output changes introduced in this PR.
  • jdx/mise#10313: Related to e2e assertions for usage complete-word task completion output formatting and zsh completion script changes.
  • jdx/mise#10176: Updates e2e assertion formatting for mise.usage.kdl output that directly track output changes to the usage file itself.

Poem

🐰 A rabbit hops through completion tests,
Adjusting whitespace—formatting quests!
Tabs and spaces in harmony dance,
Assertions now match at their rightful stance.
Small tweaks make the pipeline prance! ✨

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the primary change: updating test expectations for usage 3.5 completions in e2e tests, which aligns with the file changes and PR objectives.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Comment @coderabbitai help to get the list of available commands and usage tips.

@jdx jdx enabled auto-merge (squash) June 12, 2026 06:28
@greptile-apps

greptile-apps Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR updates zsh completion e2e test expectations to match the output format change introduced in usage 3.5, where the separator between a completion value and its description changed from a single tab to two tabs.

  • e2e/tasks/test_task_completion: one assertion updated (file-path completions with double-tab separator).
  • e2e/tasks/test_task_completion_global_cd: six assertions updated across all tested paths — baseline, global -C flag, tasks run, and orphan-short flags (-r/-S). All complete-word --shell zsh callsites in the e2e suite are covered by these two files.

Confidence Score: 5/5

Pure test-expectation update with no production code changes; straightforward to verify and easy to revert if usage 3.5 behavior changes again.

Only the two e2e test files that exercise complete-word --shell zsh exist in the repo, and both have been updated consistently throughout. No logic, scripts, or fixtures were modified.

No files require special attention.

Important Files Changed

Filename Overview
e2e/tasks/test_task_completion Updates one zsh completion assertion to use double-tab separator between completion value and description, matching usage 3.5 output format
e2e/tasks/test_task_completion_global_cd Updates six zsh completion assertions (across baseline, global -C flag, tasks run, and orphan-short flag paths) from single-tab to double-tab separator

Reviews (1): Last reviewed commit: "test(completions): update usage 3.5 expe..." | Re-trigger Greptile

@jdx jdx merged commit ddfe0c3 into main Jun 12, 2026
34 checks passed
@jdx jdx deleted the chore/update-usage-cli-3.5 branch June 12, 2026 06:37
@github-actions

Copy link
Copy Markdown

Hyperfine Performance

mise x -- echo

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.3 x -- echo 22.5 ± 1.9 19.3 28.4 1.00
mise x -- echo 24.3 ± 4.1 18.9 78.6 1.08 ± 0.20

mise env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.3 env 21.4 ± 1.4 18.7 27.2 1.00
mise env 23.3 ± 1.7 18.7 29.3 1.09 ± 0.11

mise hook-env

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.3 hook-env 24.1 ± 1.7 20.4 31.3 1.00
mise hook-env 24.9 ± 1.7 20.6 33.0 1.04 ± 0.10

mise ls

Command Mean [ms] Min [ms] Max [ms] Relative
mise-2026.6.3 ls 19.4 ± 1.6 15.7 24.7 1.00
mise ls 20.6 ± 1.7 16.4 28.9 1.06 ± 0.13

xtasks/test/perf

Command mise-2026.6.3 mise Variance
install (cached) 154ms 155ms +0%
ls (cached) 72ms 74ms -2%
bin-paths (cached) 79ms 79ms +0%
task-ls (cached) 140ms 144ms -2%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant