You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Keep the PR scoped to the test fallout from the latest usage CLI behavior
Test
mise run test:e2e e2e/tasks/test_task_completion e2e/tasks/test_task_completion_global_cd
Note
Low Risk
Test-only assertion updates with no production code or behavior changes in mise itself.
Overview
Updates zsh task-completion e2e tests to match usage 3.5 output from usage complete-word --shell zsh: the value/description pair now uses a two-tab separator instead of one.
Expected strings in test_task_completion and test_task_completion_global_cd are adjusted accordingly (e.g. alpha\talpha → alpha\t\talpha). No mise runtime or completion logic changes—only test expectations for the newer usage CLI.
Reviewed by Cursor Bugbot for commit 86133aa. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
Tests
Updated e2e test assertions for task completion output formatting to ensure accurate validation of completion behavior across various scenarios and flag combinations.
Two e2e tests update their assertion expectations to match the current completion output formatting. The first test adjusts whitespace and tab spacing in the mise.toml and mise.usage.kdl output lines. The second test updates expected profile completion strings across multiple scenarios, including baseline completion, with -C . flag variants, and with orphan flags like -r and -S.
Expected output strings updated to match current completion formatting: tab spacing and line wrapping in basic completion test; profile argument choices formatted consistently across baseline, -C ., and flag scenarios in the global flag variant test.
Estimated code review effort
🎯 2 (Simple) | ⏱️ ~8 minutes
Possibly related PRs
jdx/mise#10181: Main PR updates e2e assertions for task completion output formatting including tab-separated choice formatting, which matches the completion-output changes introduced in this PR.
jdx/mise#10313: Related to e2e assertions for usage complete-word task completion output formatting and zsh completion script changes.
jdx/mise#10176: Updates e2e assertion formatting for mise.usage.kdl output that directly track output changes to the usage file itself.
Poem
🐰 A rabbit hops through completion tests,
Adjusting whitespace—formatting quests!
Tabs and spaces in harmony dance,
Assertions now match at their rightful stance.
Small tweaks make the pipeline prance! ✨
The title clearly describes the primary change: updating test expectations for usage 3.5 completions in e2e tests, which aligns with the file changes and PR objectives.
Docstring Coverage
✅ Passed
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
✅ Passed
Check skipped because no linked issues were found for this pull request.
Description Check
✅ Passed
Check skipped - CodeRabbit’s high-level summary is enabled.
✏️ Tip: You can configure your own custom pre-merge checks in the settings.
Comment @coderabbitai help to get the list of available commands and usage tips.
This PR updates zsh completion e2e test expectations to match the output format change introduced in usage 3.5, where the separator between a completion value and its description changed from a single tab to two tabs.
e2e/tasks/test_task_completion: one assertion updated (file-path completions with double-tab separator).
e2e/tasks/test_task_completion_global_cd: six assertions updated across all tested paths — baseline, global -C flag, tasks run, and orphan-short flags (-r/-S). All complete-word --shell zsh callsites in the e2e suite are covered by these two files.
Confidence Score: 5/5
Pure test-expectation update with no production code changes; straightforward to verify and easy to revert if usage 3.5 behavior changes again.
Only the two e2e test files that exercise complete-word --shell zsh exist in the repo, and both have been updated consistently throughout. No logic, scripts, or fixtures were modified.
No files require special attention.
Important Files Changed
Filename
Overview
e2e/tasks/test_task_completion
Updates one zsh completion assertion to use double-tab separator between completion value and description, matching usage 3.5 output format
e2e/tasks/test_task_completion_global_cd
Updates six zsh completion assertions (across baseline, global -C flag, tasks run, and orphan-short flag paths) from single-tab to double-tab separator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test
Note
Low Risk
Test-only assertion updates with no production code or behavior changes in mise itself.
Overview
Updates zsh task-completion e2e tests to match usage 3.5 output from
usage complete-word --shell zsh: the value/description pair now uses a two-tab separator instead of one.Expected strings in
test_task_completionandtest_task_completion_global_cdare adjusted accordingly (e.g.alpha\talpha→alpha\t\talpha). No mise runtime or completion logic changes—only test expectations for the newer usage CLI.Reviewed by Cursor Bugbot for commit 86133aa. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit