test(task): update zsh completion expectations for usage 3.5 three-column output#10328
Conversation
…lumn output usage v3.5.0 (jdx/usage#666, "Zsh Colon Fixes") changed `complete-word --shell zsh` from a two-column `value<TAB>insert` layout to an unconditional three-column `value<TAB>description<TAB>insert`. When a completion has no description (file/choice completions) the now-always-present empty middle column yields `value<TAB><TAB>insert`. mise already moved to usage 3.5 in jdx#10313 (regenerated completions/_mise to the three-column consumer; pinned usage-lib and mise.lock to 3.5.0), but these two e2e tests still asserted the old single-TAB output. They install the usage tool with version = "latest", so they started failing once the default 24h release-age window let "latest" resolve to v3.5.0. Update the expected completion lines to the three-column format (insert the empty description column). Test-only change; no behavior change. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughTwo e2e test files update expected output assertion strings to match revised completion and ChangesTask Completion Output Formatting
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryFixes two failing e2e tests by updating their expected strings to match the three-column zsh completion output introduced in usage v3.5.0 — every
Confidence Score: 5/5Safe to merge — purely a test expectation update with no production code touched. Both files only update hardcoded string literals inside No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "test(task): update zsh completion expect..." | Re-trigger Greptile |
Problem
Two task-completion e2e tests have been failing on
main:e2e/tasks/test_task_completion(CIe2e-3)e2e/tasks/test_task_completion_global_cd(CIe2e-4)They assert the output of
usage complete-word --shell zsh. usage v3.5.0 (jdx/usage#666, "Zsh Colon Fixes") intentionally changed that output from a two-columnvalue<TAB>insertlayout to an unconditional three-columnvalue<TAB>description<TAB>insert. For completions with no description (the file/choice completions these tests exercise), the now-always-present empty middle column produces a double tab — e.g.mise.toml\t\tmise.tomlandalpha\t\talpha— where the tests still expected a single tab.mise already adopted the new format in #10313 (regenerated
completions/_miseto the three-column consumer and pinned usage-lib /mise.lockto 3.5.0), but these two e2e expectation strings were not updated. Because the tests install theusagetool withversion = "latest", they only went red once the default 24hminimum_release_agewindow letlatestresolve to v3.5.0 (~24h after the v3.5.0 release) — which is why #10313's own CI was still green at merge time.Change
Update the expected completion lines in both tests to the three-column format (insert the empty description column:
value\t\tvalue). Test-only change — no behavior change. The new format is corroborated by the CI's actual output and by usage v3.5.0's own unit test (complete_word_zsh_three_columns_without_descriptions).The tests keep
usage = { version = "latest" }; pinning to a concrete version to avoid tracking future usage format changes is left as a separate maintainer decision.Refs jdx/usage#666, #10313.
This pull request was prepared with the help of an AI coding assistant.
🤖 Generated with Claude Code
Summary by CodeRabbit