Skip to content

test(e2e): assert captured output without shell eval #10257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 1 commit into from
Jun 6, 2026
Merged

test(e2e): assert captured output without shell eval #10257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions e2e/assert.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,15 @@ assert_contains() {
fi
}

assert_contains_text() {
local actual="$1"
if [[ $actual == *"$2"* ]]; then
ok "[text] '$2' is in output"
else
fail "[text] expected '$2' to be in output"
fi
}
Comment thread
greptile-apps[bot] marked this conversation as resolved.

assert_not_contains() {
local actual
actual="$(quiet_assert_succeed "$1")"
Expand All @@ -260,6 +269,15 @@ assert_not_contains() {
fi
}

assert_not_contains_text() {
local actual="$1"
if [[ $actual != *"$2"* ]]; then
ok "[text] '$2' is not in output"
else
fail "[text] expected '$2' not to be in output"
fi
}

assert_matches() {
local actual
actual="$(quiet_assert_succeed "$1")"
Expand Down
4 changes: 2 additions & 2 deletions e2e/core/test_python_github_attestations
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ output=$(mise install python@3.13.5 2>&1) || true
echo "$output"

# Verify attestation verification was attempted and succeeded
assert_contains "echo \"$output\"" "verify GitHub artifact attestations"
assert_contains "echo \"$output\"" "✓ GitHub artifact attestations verified"
assert_contains_text "$output" "verify GitHub artifact attestations"
assert_contains_text "$output" "✓ GitHub artifact attestations verified"

# Verify the installed Python works
assert "mise x python@3.13.5 -- python --version" "Python 3.13.5"
Loading