fix: nix flake build test failure#10243
Conversation
Adding the `git::tests::clone_by_sha_does_not_panic` broke nix flake builds as `git` was not available during tests. Adding it to `nativeCheckInputs` fixes the issue.
|
Linter diff in the way? Review this PR in Change Stack to focus on meaningful changes and expand context only when needed. No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughThe ChangesBuild Configuration
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR fixes a Nix flake build test failure by adding
Confidence Score: 5/5Single-line addition to a Nix build file; no logic changes, no runtime behavior affected. The change is a targeted, well-understood Nix convention fix — adding No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix: nix flake build test failure" | Re-trigger Greptile |
|
Basically the same issue as with #10005, only with nix instead of Arch. |
Adding the
git::tests::clone_by_sha_does_not_panicbroke nix flake builds asgitwas not available during tests. Adding it tonativeCheckInputsfixes the issue.Summary by CodeRabbit