fix(github): accept canonical repo casing from versions host#10205
fix(github): accept canonical repo casing from versions host#10205risu729 wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Greptile SummaryThis PR fixes a false-positive "invalid mise-versions asset URL" warning triggered when a user installs a GitHub tool whose repo name is mixed-case (e.g.
Confidence Score: 5/5The change is minimal and well-scoped: it only loosens casing for GitHub owner/repo segments in URL validation, matching GitHub's own case-insensitive treatment of those names, and leaves all other checks (host, tag, path structure) unchanged. The fix is a single-line function wrapping eq_ignore_ascii_case applied in exactly two validation call sites, directly mirroring how GitHub itself treats owner/repo identifiers. The tag remains case-sensitive (correct, since git tags are case-sensitive), and host checks are untouched. Regression tests cover the exact reported failure scenario and there are no pre-existing tests this change could silently break. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(github): accept canonical repo casin..." | Re-trigger Greptile |
|
Superseded by the proxy-side fix in jdx/mise-versions#214. The client-side casing tolerance was too narrow: the underlying issue also affects renamed or transferred repositories, so the release mirror should follow GitHub redirects and return asset URLs matching the requested backend slug. This comment was generated by an AI coding assistant. |
|
Closing as superseded by jdx/mise-versions#214. This comment was generated by an AI coding assistant. |
Summary
Context
Addresses #10198. The cause is GitHub returning canonical repo casing in release asset URLs for a mixed-case API request.
Testing
github:Dicklesworthstone/Destructive_command_guard@v0.5.6no longer emits the invalid mise-versions asset URL warning