Skip to content

fix(use): reject leading-dash tool versions #10113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jdx merged 2 commits into from
May 28, 2026
Merged

fix(use): reject leading-dash tool versions #10113

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b4034e0
fix(use): reject leading-dash tool versions
jdx May 28, 2026
6b65680
fix(use): reject leading-dash ref versions
jdx May 28, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions e2e/cli/test_use
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,10 @@ mise use --pin dummy@1
assert "cat mise.toml" '[tools]
dummy = "1.0.0"'

assert_fail "mise use dummy@--version" "must not start with '-'"
assert "cat mise.toml" '[tools]
dummy = "1.0.0"'

MISE_PIN=1 mise use --fuzzy dummy@1
assert "cat mise.toml" '[tools]
dummy = "1"'
Expand Down
9 changes: 8 additions & 1 deletion src/toolset/tool_request.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -413,11 +413,15 @@ impl ToolRequest {
/// semver ranges like `>=20 <21 || >=22` or `^1.0.0`, dates, channel names,
/// `lts/hydrogen`, etc.) continues to work — those characters are only
/// dangerous in *unquoted* shell context, which cannot occur without one of
/// the rejected expansion characters appearing first.
/// the rejected expansion characters appearing first. Leading dashes are also
/// rejected so backend install tools cannot mistake a version for a CLI flag.
fn validate_version_string(s: &str) -> Result<()> {
if s.is_empty() {
return Ok(());
}
if s.starts_with('-') {
bail!("invalid tool version {s:?}: must not start with '-'");
}
if s.contains("..") {
bail!("invalid tool version {s:?}: contains path-traversal sequence");
}
Expand Down Expand Up @@ -612,6 +616,9 @@ mod tests {
"1.0\"x",
"1.0'x",
"1.0\\x",
// backend commands could parse leading dashes as flags
"--version",
"-v",
// control characters / newline splitting
"1.0\nrm",
"1.0\rrm",
Expand Down
Loading